Skip to content

Fixed FallingBlocks not landing on aeronautics sructures 修复了重力方块无法着陆在航空学的物理结构上的问题#3425

Merged
Gu-ZT merged 1 commit intoAnvil-Dev:dev/1.21/1.6from
WhereisFff:fix/#3422
Apr 21, 2026
Merged

Fixed FallingBlocks not landing on aeronautics sructures 修复了重力方块无法着陆在航空学的物理结构上的问题#3425
Gu-ZT merged 1 commit intoAnvil-Dev:dev/1.21/1.6from
WhereisFff:fix/#3422

Conversation

@WhereisFff
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts falling-block landing logic so that in normal “downward gravity” conditions it relies on vanilla onGround() behavior, which helps falling blocks correctly land on entity-based/physics structures (e.g., Aeronautics).

Changes:

  • Added a “normal downward gravity” fast-path in FallingBlockEntityMixin to bypass custom landing logic and defer to vanilla onGround().
  • Simplified AnvilBlockMixin#tick to only short-circuit when a magnet attraction condition is present, otherwise delegating to super.tick.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/main/java/dev/dubhe/anvilcraft/mixin/FallingBlockEntityMixin.java Adds an early-return path so vanilla grounding is used under normal downward gravity.
src/main/java/dev/dubhe/anvilcraft/mixin/AnvilBlockMixin.java Removes redundant preconditions in tick, keeping only the magnet-attraction guard before calling super.tick.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Gu-ZT Gu-ZT merged commit f97f002 into Anvil-Dev:dev/1.21/1.6 Apr 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants