Fixed FallingBlocks not landing on aeronautics sructures 修复了重力方块无法着陆在航空学的物理结构上的问题#3425
Merged
Gu-ZT merged 1 commit intoAnvil-Dev:dev/1.21/1.6from Apr 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts falling-block landing logic so that in normal “downward gravity” conditions it relies on vanilla onGround() behavior, which helps falling blocks correctly land on entity-based/physics structures (e.g., Aeronautics).
Changes:
- Added a “normal downward gravity” fast-path in
FallingBlockEntityMixinto bypass custom landing logic and defer to vanillaonGround(). - Simplified
AnvilBlockMixin#tickto only short-circuit when a magnet attraction condition is present, otherwise delegating tosuper.tick.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/java/dev/dubhe/anvilcraft/mixin/FallingBlockEntityMixin.java |
Adds an early-return path so vanilla grounding is used under normal downward gravity. |
src/main/java/dev/dubhe/anvilcraft/mixin/AnvilBlockMixin.java |
Removes redundant preconditions in tick, keeping only the magnet-attraction guard before calling super.tick. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Gu-ZT
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.