Repository navigation
Pin workflow steps to the Agent version they were saved with - #1674
Open
tataru-dan wants to merge 2 commits into
Open
tataru-dan wants to merge 2 commits into
tataru-dan wants to merge 2 commits into
Conversation
Each Agent save now records a version (config + hash) in its history. AgentRun stamps the Agent id and version it ran with, surfaced through the CLI, the Agent's Versions tab (used by, diff between versions), and step status with a staleness flag when the Agent moved on. Retrying a step now refuses to silently rerun it on a different Agent version unless allowAgentDrift is explicitly passed.
…ed with A step now carries its own agentVersion, set when its Agent is picked and changed only by a manual edit in the step editor's version picker. Execution resolves identity, model, MCP servers and Skills from that pinned version's snapshot instead of the Agent's live document, so a later Agent edit never changes what an already saved step runs. Retry compares against the pin instead of the Agent's current version, so a pinned step never trips the drift guard. Also fixes two display bugs found while building this: hover buttons on a workflow step overlapping its version badge, and the Agent Versions tab linking to a dead route with no workflow name shown.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1673
Description
Agent definitions have been versioned since ADR-0029 (every save or eval hashes the config and appends an immutable
AgentVersionrow), but that versioning only fed Eval Runs. A production Workflow step resolved its Agent live at execution time and never recorded which version actually ran, so editing an Agent after a Workflow used it could silently change what a step does mid-run, and retrying a failed step could rerun it on a different Agent than the one that originally ran it.This PR closes that gap end to end, in two commits.
Commit 1: track which Agent version a workflow step actually ran
AgentVersion(config snapshot + hash) to its history.AgentRunnow stamps theagentIdandagentVersionthe step actually ran with, recorded by the agent runner and exposed through the CLI (agent-run-get,agent-run-list).v{N}for the version that ran, flagged amber when the Agent has since moved on.allowAgentDriftis explicitly passed.propose_agent_update), not just creating new ones or adding a Skill — this is the "unblock Agent editing from the assistant" piece of the epic, now that a change is reproducible.Commit 2: pin a workflow step to the Agent version it was saved with
agentVersion, written automatically when its Agent is picked in the step editor's "Agent" dropdown, and changed only by a manual edit via a new "Agent version" picker next to it (or an explicit "Track current" choice for a step that should keep following the Agent live).How to test
allowAgentDrift— it should succeed, using the pinned version, not refuse.Definition of Done
platform-core,agent-runtime,platform-api,platform-ui,cli.Closes
Closes #1673 — all workstreams (A1, B1, B2, C1, C2, C3, D1, E1) are covered by this PR.