feat(gui): render native application icons in Actions Ring - #1207
Open
foleykyle01 wants to merge 5 commits into
Open
feat(gui): render native application icons in Actions Ring#1207foleykyle01 wants to merge 5 commits into
foleykyle01 wants to merge 5 commits into
Conversation
Greptile SummaryThe PR adds native application icons to uncustomized Open Application slots and aligns the Actions Ring application picker with the profile application catalog.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/openlogi-desktop/src/features/profiles/catalog.rs | Adds launch-target resolution for catalog entries; Linux and Windows use executable paths, resolving the previously reported registration-file launch defect. |
| crates/openlogi-desktop/src/features/profiles/picker.rs | Reuses the application catalog for Actions Ring selection while filtering choices that lack a launchable target. |
| crates/openlogi-agent-core/src/action_ring.rs | Publishes exact application targets as presentation-only icon hints when no explicit custom icon exists. |
| crates/openlogi-ipc/src/ipc.rs | Extends the versioned ring presentation contract with an optional application icon target. |
| crates/openlogi-ui/src/application_icon.rs | Implements shared native application icon loading and caching for desktop and overlay consumers. |
| crates/openlogi-overlay/src/ring.rs | Renders native application icons from ring presentation hints with generic fallback behavior. |
Sequence Diagram
sequenceDiagram
participant User
participant Desktop as Desktop picker
participant Catalog as Application catalog
participant Agent as Agent core
participant IPC
participant Overlay
User->>Desktop: Select Open Application
Desktop->>Catalog: Resolve launch target and native icon
Catalog-->>Desktop: Executable or application bundle path
Desktop->>Agent: Persist Actions Ring configuration
Agent->>IPC: Publish ring presentation with icon target
IPC->>Overlay: Observe invocation
Overlay->>Overlay: Load and cache native icon
Overlay-->>User: Render Actions Ring
Reviews (2): Last reviewed commit: "fix(gui): use executable application lau..." | Re-trigger Greptile
|
Want your agent to iterate on Greptile's feedback? Start a greploop in Codex and it will work through the open comments and keep going until this PR reviews clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing
cargo fmt --all -- --checkRUSTFLAGS='-D warnings' cargo clippy --workspace --all-targets -- -D warningsRUSTFLAGS='-D warnings' cargo test --workspaceRUSTDOCFLAGS='-D warnings' cargo doc --workspace --no-deps --document-private-items --exclude openlogi-ui --exclude openlogi-desktop --exclude openlogi-overlay --exclude openlogi-agentcargo xtask ci clippy-windowsopenlogi-agent-mockand the real dev app: recent native icons, collapsed All applications, search auto-reveal, manual Safari path, Calendar selection, Settings preview icons, and the standalone overlay Safari icon.cargo-denynot run locally because cargo-deny/Nix is unavailable; CI provides that job.Fixes #875