feat(core): add PageUp and PageDown actions across all backends - #1208
Open
FeliciaFiction wants to merge 2 commits into
Open
feat(core): add PageUp and PageDown actions across all backends#1208FeliciaFiction wants to merge 2 commits into
FeliciaFiction wants to merge 2 commits into
Conversation
Greptile SummaryAdds bindable Page Up and Page Down actions throughout the core action model, action picker, platform injection backends, IPC versioning, and localized resources.
Confidence Score: 5/5The PR appears safe to merge within the scope of eligible follow-up findings. No blocking eligible failure remains.
|
| Filename | Overview |
|---|---|
| crates/openlogi-core/src/binding/action.rs | Appends PageUp and PageDown actions and adds them to the generated action catalog. |
| crates/openlogi-core/src/binding/effect.rs | Classifies the new actions as shared shortcuts. |
| crates/openlogi-inject/src/inject/linux.rs | Maps Page Up and Page Down to their existing Linux key-code conversions. |
| crates/openlogi-inject/src/inject/macos.rs | Maps Page Up and Page Down to their existing macOS virtual-key conversions. |
| crates/openlogi-inject/src/inject/windows.rs | Maps Page Up and Page Down to their existing Windows virtual-key conversions. |
| crates/openlogi-ipc/src/ipc.rs | Increments the strict IPC protocol version to 30. |
| crates/openlogi-ipc/tests/wire_format.rs | Updates the pinned protocol-version assertion. |
Reviews (3): Last reviewed commit: "Merge branch 'AprilNEA:master' into feat..." | Re-trigger Greptile
Add bindable Page Up and Page Down actions (USB HID usages 0x4b and 0x4e). These share one physical key usage across all platforms, so they use a single Shortcut enum variant and KeyCombo mapping in each inject backend (Linux, macOS, Windows). - Action::PageUp / Action::PageDown in openlogi-core - Shortcut::PageUp / Shortcut::PageDown with completeness test coverage - Icon mapping in action picker (chevrons-up / chevrons-down) - IPC protocol version bump to 30 - Locale entries in all 23 translation files
FeliciaFiction
force-pushed
the
feat/pageup-pagedown
branch
from
August 31, 2026 21:06
a4e44b0 to
a2fb505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bindable Page Up and Page Down actions (USB HID usages 0x4b and 0x4e). These share one physical key usage across all platforms, so they use a single Shortcut enum variant and KeyCombo mapping in each inject backend (Linux, macOS, Windows).
Related to #1190