Skip to content

feat(core): add PageUp and PageDown actions across all backends - #1208

Open
FeliciaFiction wants to merge 2 commits into
AprilNEA:masterfrom
FeliciaFiction:feat/pageup-pagedown
Open

feat(core): add PageUp and PageDown actions across all backends#1208
FeliciaFiction wants to merge 2 commits into
AprilNEA:masterfrom
FeliciaFiction:feat/pageup-pagedown

Conversation

@FeliciaFiction

@FeliciaFiction FeliciaFiction commented Aug 31, 2026

Copy link
Copy Markdown

Add bindable Page Up and Page Down actions (USB HID usages 0x4b and 0x4e). These share one physical key usage across all platforms, so they use a single Shortcut enum variant and KeyCombo mapping in each inject backend (Linux, macOS, Windows).

  • Action::PageUp / Action::PageDown in openlogi-core
  • Shortcut::PageUp / Shortcut::PageDown with completeness test coverage
  • Icon mapping in action picker (chevrons-up / chevrons-down)
  • IPC protocol version bump to 30
  • Locale entries in all 23 translation files

Related to #1190

@greptile-apps

greptile-apps Bot commented Aug 31, 2026

Copy link
Copy Markdown

Greptile Summary

Adds bindable Page Up and Page Down actions throughout the core action model, action picker, platform injection backends, IPC versioning, and localized resources.

  • Maps the actions to USB HID usages 0x4b and 0x4e on Linux, macOS, and Windows.
  • Adds picker icons and translations across all supported locales.
  • Increments the IPC protocol version to 30.

Confidence Score: 5/5

The PR appears safe to merge within the scope of eligible follow-up findings.

No blocking eligible failure remains.

Important Files Changed

Filename Overview
crates/openlogi-core/src/binding/action.rs Appends PageUp and PageDown actions and adds them to the generated action catalog.
crates/openlogi-core/src/binding/effect.rs Classifies the new actions as shared shortcuts.
crates/openlogi-inject/src/inject/linux.rs Maps Page Up and Page Down to their existing Linux key-code conversions.
crates/openlogi-inject/src/inject/macos.rs Maps Page Up and Page Down to their existing macOS virtual-key conversions.
crates/openlogi-inject/src/inject/windows.rs Maps Page Up and Page Down to their existing Windows virtual-key conversions.
crates/openlogi-ipc/src/ipc.rs Increments the strict IPC protocol version to 30.
crates/openlogi-ipc/tests/wire_format.rs Updates the pinned protocol-version assertion.

Reviews (3): Last reviewed commit: "Merge branch 'AprilNEA:master' into feat..." | Re-trigger Greptile

Add bindable Page Up and Page Down actions (USB HID usages 0x4b and
0x4e). These share one physical key usage across all platforms, so they
use a single Shortcut enum variant and KeyCombo mapping in each inject
backend (Linux, macOS, Windows).

- Action::PageUp / Action::PageDown in openlogi-core
- Shortcut::PageUp / Shortcut::PageDown with completeness test coverage
- Icon mapping in action picker (chevrons-up / chevrons-down)
- IPC protocol version bump to 30
- Locale entries in all 23 translation files
@davidbudnick davidbudnick added type: feature New feature request platform: all Cross-platform issue labels Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: all Cross-platform issue type: feature New feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants