-
Notifications
You must be signed in to change notification settings - Fork 82
PagerDuty typed OAuth object #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a typed PagerDuty OAuth2 provider to the Arcade platform, making it available across core, TDK, and MCP server packages with appropriate version bumps.
- Introduces the
PagerDutyOAuth2 provider class inarcade-core - Exports
PagerDutyfrom TDK and MCP server auth modules - Updates version constraints to ensure consistency across packages
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libs/arcade-core/pyproject.toml | Bumps arcade-core version to 3.5.0 to include the new PagerDuty provider |
| libs/arcade-core/arcade_core/auth.py | Adds PagerDuty OAuth2 provider class with provider_id "pagerduty" |
| libs/arcade-tdk/pyproject.toml | Updates to version 3.3.0 and requires arcade-core>=3.5.0 |
| libs/arcade-tdk/arcade_tdk/auth/init.py | Exports PagerDuty from core auth module |
| libs/arcade-mcp-server/pyproject.toml | Updates to version 1.12.0 and requires arcade-core>=3.5.0 |
| libs/arcade-mcp-server/arcade_mcp_server/auth/init.py | Exports PagerDuty from core auth module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EricGustin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming engine changes are already deployed
Note
Adds a typed
PagerDutyOAuth2 provider and wires it through TDK/MCP exports, with tests and coordinated version/dependency bumps.PagerDuty(provider_id="pagerduty") inarcade_core/auth.py.PagerDutyinarcade_tdk/auth/__init__.pyandarcade_mcp_server/auth/__init__.py.test_tool_decorator.pyandtest_create_tool_definition.pyto coverPagerDutysuccess/failure and tool requirement generation.arcade-core→4.1.0,arcade-tdk→3.4.0,arcade-mcp-server→1.14.0, rootarcade-mcp→1.7.1.Written by Cursor Bugbot for commit 2b60261. This will update automatically on new commits. Configure here.