Skip to content

Conversation

@jottakka
Copy link
Contributor

@jottakka jottakka commented Dec 8, 2025

Note

Adds a typed PagerDuty OAuth2 provider and wires it through TDK/MCP exports, with tests and coordinated version/dependency bumps.

  • Auth (core):
    • Add typed OAuth2 provider PagerDuty (provider_id="pagerduty") in arcade_core/auth.py.
  • TDK & MCP Server:
    • Re-export PagerDuty in arcade_tdk/auth/__init__.py and arcade_mcp_server/auth/__init__.py.
  • Tests:
    • Extend test_tool_decorator.py and test_create_tool_definition.py to cover PagerDuty success/failure and tool requirement generation.
  • Versioning/Deps:
    • Bump versions: arcade-core4.1.0, arcade-tdk3.4.0, arcade-mcp-server1.14.0, root arcade-mcp1.7.1.
    • Update dependency ranges to require the bumped versions.

Written by Cursor Bugbot for commit 2b60261. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jottakka jottakka self-assigned this Dec 8, 2025
@jottakka jottakka requested a review from Copilot December 8, 2025 01:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a typed PagerDuty OAuth2 provider to the Arcade platform, making it available across core, TDK, and MCP server packages with appropriate version bumps.

  • Introduces the PagerDuty OAuth2 provider class in arcade-core
  • Exports PagerDuty from TDK and MCP server auth modules
  • Updates version constraints to ensure consistency across packages

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libs/arcade-core/pyproject.toml Bumps arcade-core version to 3.5.0 to include the new PagerDuty provider
libs/arcade-core/arcade_core/auth.py Adds PagerDuty OAuth2 provider class with provider_id "pagerduty"
libs/arcade-tdk/pyproject.toml Updates to version 3.3.0 and requires arcade-core>=3.5.0
libs/arcade-tdk/arcade_tdk/auth/init.py Exports PagerDuty from core auth module
libs/arcade-mcp-server/pyproject.toml Updates to version 1.12.0 and requires arcade-core>=3.5.0
libs/arcade-mcp-server/arcade_mcp_server/auth/init.py Exports PagerDuty from core auth module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jottakka jottakka requested review from EricGustin and byrro December 8, 2025 01:17
Copy link
Member

@EricGustin EricGustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming engine changes are already deployed

@jottakka jottakka requested a review from sdreyer December 15, 2025 19:21
@jottakka jottakka merged commit 7a06bdf into main Dec 15, 2025
14 checks passed
@jottakka jottakka deleted the francisco/pagerduty-typed-oauth branch December 15, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants