[GH-92] Fixed temp file and batch size for fetch_uniprot_metadata.py#93
Merged
Conversation
Contributor
|
I think we can merge this as-is. The CI is failing but only because of a deprecated workflow version, which we'll need to fix that in a subsequent PR. I tested this PR manually and also ran the tests locally. For extra clarity for the record, this PR fixes two essentially unrelated problems in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
pandasread_csvfailed. 300 for the UniProt API batch size was not working anymore. I reduced it to 100.condaenvironments.