Skip to content

[GH-92] Fixed temp file and batch size for fetch_uniprot_metadata.py#93

Merged
keithchev merged 1 commit into
Arcadia-Science:mainfrom
GallVp:fix/92
Sep 24, 2025
Merged

[GH-92] Fixed temp file and batch size for fetch_uniprot_metadata.py#93
keithchev merged 1 commit into
Arcadia-Science:mainfrom
GallVp:fix/92

Conversation

@GallVp

@GallVp GallVp commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

PR checklist

@keithchev keithchev self-requested a review September 24, 2025 18:09

@keithchev keithchev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GallVp Thanks so much for fixing this!

@keithchev

Copy link
Copy Markdown
Contributor

I think we can merge this as-is. The CI is failing but only because of a deprecated workflow version, which we'll need to fix that in a subsequent PR. I tested this PR manually and also ran the tests locally.

For extra clarity for the record, this PR fixes two essentially unrelated problems in fetch_uniprot_metadata.py:

  • It decreases the batch size used to query the UniProt API from 300 to 100. Since we know the old batch size of 300 used to work, this presumably reflects a change made on the UniProt side.
  • It fixes a bug that caused the script to crash when the temp file used to cache previously fetched accessions was empty (which only happened if the script failed to retrieve any accessions and then also crashed, leaving an empty temp file behind).

@keithchev keithchev merged commit 2979aee into Arcadia-Science:main Sep 24, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fetch_uniprot_metadata.py returns bad request from an empty temp file

2 participants