Increase timeout in ID mapping script#95
Merged
Merged
Conversation
6b7a18f to
75350e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address #94 by increasing the timeout in the
map_refseq_ids.pyscript. As far as I can tell, the UniProt mapping API is unchanged but may have become slower, resulting in the script failing if the mapping job takes longer than the previous timeout (of 300 seconds).This PR increases the timeout to 3000 seconds.
Anecdotally, the mapping requests for the two default databases ("EMBL-GenBank-DDBJ_CDS" and "RefSeq_Protein") are currently taking around 800 seconds and 150 seconds, respectively.
Driveby changes
map_refseq_ids.pyfor clarity.Testing
I tested the
map_refseq_ids.pyscript manually and ran the tests locally. The CI is currently broken.PR checklist
Fixes #123, Resolves #456).