MOve MAV_CMD_GUIDED_CHANGE_{SPEED/ALTITUDE} to common.xml#509
Open
hamishwillee wants to merge 2 commits into
Open
MOve MAV_CMD_GUIDED_CHANGE_{SPEED/ALTITUDE} to common.xml#509hamishwillee wants to merge 2 commits into
hamishwillee wants to merge 2 commits into
Conversation
|
I'm fine with this, but @davidbuzz should also be happy. |
peterbarker
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We moved
MAV_CMD_GUIDED_CHANGE_HEADINGfrom ardupilotmega.xml to common.xml last week. IN mavlink#2493 (comment) @davidbuzz pointed out that this is normally used withMAV_CMD_GUIDED_CHANGE_SPEEDandMAV_CMD_GUIDED_CHANGE_ALTITUDE.This PR is to explore the appetite of ArduPilot for moving the commands - which makes sense as it groups like with like.
Note, 2 commits - the first is a direct copy, and the second is minor modifications for mavlink/mavlink.
@davidbuzz @rmackay9 @peterbarker This was discussed in the MAV call. We're not opposed, but we wanted to make sure this seems reasonable to you. If so, I will create a companion PR in mavlink/mavlink and get buy-in there too.
FYI Under the way we are running common.xml at the moment something can go into common.xml if it is supported in two stakeholder stacks, or by one stakeholder stack and the other either plans to take it, or accepts that it is "good" but doesn't need it right now. We don't accept things otherwise - such as "not considered a good design that can be standardised". We're slowing moving things that are truly standard to standard.xml.