upgrade to pyo3 0.28#97
Open
Johann150 wants to merge 8 commits intoArniDagur:masterfrom
Open
Conversation
- no relevant changes 0.16 -> 0.17 - two relevant changes in 0.17 -> 0.18 https://pyo3.rs/main/migration.html#from-017-to-018 - text signature is automatically generated - required arguments after Option<_> no longer inferred
- no relevant changes in 0.18 -> 0.19 - two relevant change in 0.19 -> 0.20 https://pyo3.rs/main/migration.html#from-019-to-020 - minimum Rust version raised to 1.56 - removed #[args] in favour of #[pyo3(signature=...)]
Convert to using the pyo3::Bound smart pointer instead of refs. In the case of the use_tags, enable_tags and disable_tags functions, it would alternatively be possible to use Vec<PyBackedStr> but this seems to me to be even more complicated.
Implicit default for trailing optional arguments deprecated.
gil-refs feature removed and _bound functions have now become the "normal" versions of the respective functions.
no relevant changes in 0.23 -> 0.27
one relevant change in 0.27 -> 0.28
- deprecation of automatic FromPyObject for #[pyclass]
- because of the use in Engine::new, the FromPyObject is needed for
FilterSet, so it is explicity enabled.
Author
|
closes #89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the pyo3 rust crate to the current version going by the pyo3 migration guide. See the individual commit messages for further details.