This repository was archived by the owner on Jun 14, 2026. It is now read-only.
forked from L4GSP1KE/Upload-Assistant
-
Notifications
You must be signed in to change notification settings - Fork 137
feat(trackers/spd): handle staff reservations #1387
Open
HichamLL04
wants to merge
3
commits into
Audionut:master
Choose a base branch
from
HichamLL04:feat/spd_reservations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't treat “claims check failed” as “not claimed”.
This branch returns SPD's raw boolean straight into the normal claims flow. In
src/trackerstatus.py:94-105, that result is collapsed intolocal_tracker_status['skipped'] = bool(claimed), so theFalsereturned bySPD.get_claims()on missing API keys, 403s, and transport errors becomes “safe to upload”. That makes the new staff-reservation guard fail open whenever the API cannot be verified.🛡️ Suggested contract change
if tracker.upper() == "SPD": if hasattr(tracker_instance, 'get_claims'): - return await tracker_instance.get_claims(meta) + claimed = await tracker_instance.get_claims(meta) + if claimed is None: + meta['tracker_status'].setdefault(tracker, {})['skip_upload'] = True + return True + return claimed return NoneAnd have
SPD.get_claims()returnNonefor configuration/API failures instead ofFalse.🤖 Prompt for AI Agents