-
Notifications
You must be signed in to change notification settings - Fork 25
fix(bindings): Python out parameter handling and improve C# wrapper visibility #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes binding issues for both C# and Python in the Automatic Component Toolkit (ACT). The changes improve C# wrapper class visibility and enhance Python out parameter handling for better backwards compatibility.
- Adds 'public' modifier to C# Wrapper class to fix accessibility issues
- Refactors Python out parameter handling to support optional input parameters with default None values
- Maintains backward compatibility in Python bindings while improving parameter processing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
LGTM |
Source/buildbindingpython.go
Outdated
| preCallLines = append(preCallLines, fmt.Sprintf("%s = %s(len(%s))", cParams[0].ParamName, cParams[0].ParamCallType, param.ParamName)) | ||
| preCallLines = append(preCallLines, fmt.Sprintf("%s = (%s*len(%s))(*%s)", cParams[1].ParamName, cParams[1].ParamCallType, param.ParamName, param.ParamName)) | ||
| pythonInParams = pythonInParams + param.ParamName | ||
| inParamsSig = append(inParamsSig, param.ParamName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting seems off
|
looks good now, except for some incorrect indentation in Source/buildbindingpython.go. |
|
Hi @martinweismann, I've fixed the indentations. Also, checked the changes in lib3mf; the example scripts work without any issues. Here are the differences in Lib3mf.py 3MFConsortium/lib3mf@1ab0f8d |
martinweismann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now!
C# Binding Fix:
Python Binding Enhancement: