Merged
Conversation
veselinovviktor
assigned
veselinovviktor,
n1xan and
teo-nikolov and unassigned
veselinovviktor
teo-nikolov
reviewed
Jul 21, 2025
bellatrix.data/src/main/java/solutions/bellatrix/data/http/infrastructure/HttpRepository.java
Outdated
Show resolved
Hide resolved
teo-nikolov
reviewed
Jul 21, 2025
bellatrix.core/src/main/java/solutions/bellatrix/core/configuration/ConfigurationService.java
Outdated
Show resolved
Hide resolved
n1xan
reviewed
Jul 21, 2025
...ix.data/src/main/java/solutions/bellatrix/data/http/authentication/AuthenticationMethod.java
Outdated
Show resolved
Hide resolved
n1xan
reviewed
Jul 21, 2025
| } | ||
|
|
||
| public static HttpSettings custom(Consumer<HttpSettings> httpSettings) { | ||
| var settings = ConfigurationService.get(DataSettings.class).getHttpSettings(); |
Collaborator
There was a problem hiding this comment.
handle the case when such settings are not present in the config - maybe Log warning or throw specific exception, but this will happen in all existing projects, so its better not to break the execution if the module is not used
n1xan
reviewed
Jul 21, 2025
| } | ||
|
|
||
| public RequestSpecification requestSpecification() { | ||
| if (requestBody!=null) { |
n1xan
approved these changes
Jul 21, 2025
teo-nikolov
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.