Feature/service now module initial setup#77
Merged
EliNedyalkova merged 20 commits intomainfrom Aug 12, 2025
Merged
Conversation
n1xan
reviewed
Jul 28, 2025
getting-started/bellatrix.servicenow.getting.started/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
n1xan
reviewed
Jul 28, 2025
...bellatrix.servicenow.getting.started/src/main/resources/testFrameworkSettings.dev329858.json
Show resolved
Hide resolved
n1xan
reviewed
Jul 28, 2025
getting-started/bellatrix.servicenow.getting.started/src/test/java/O1_Login/readme.txt
Outdated
Show resolved
Hide resolved
n1xan
reviewed
Jul 28, 2025
getting-started/bellatrix.servicenow.getting.started/src/test/java/O1_Login/readme.txt
Outdated
Show resolved
Hide resolved
n1xan
reviewed
Jul 28, 2025
getting-started/bellatrix.servicenow.getting.started/src/test/java/O1_Login/readme.txt
Outdated
Show resolved
Hide resolved
n1xan
reviewed
Jul 28, 2025
getting-started/bellatrix.servicenow.getting.started/src/test/java/O1_Login/readme.txt
Outdated
Show resolved
Hide resolved
n1xan
reviewed
Jul 28, 2025
...ed/bellatrix.servicenow.getting.started/src/test/java/O4_TableView/data/ReservationForm.java
Outdated
Show resolved
Hide resolved
n1xan
reviewed
Aug 5, 2025
| import java.util.Collection; | ||
|
|
||
| public class TestDataFacade { | ||
| @Deprecated(since = "Use MapperUtility instead of this field.", forRemoval = true) |
Collaborator
There was a problem hiding this comment.
you can update this and remove the depricated tag
n1xan
reviewed
Aug 5, 2025
|
|
||
| import java.lang.reflect.Type; | ||
|
|
||
| public class CustomGsonObjectMapperFactory implements GsonObjectMapperFactory { |
Collaborator
There was a problem hiding this comment.
this should not be needed with the Data module - check if you can remove it
n1xan
reviewed
Aug 5, 2025
| public class CurlLoggingFilter implements Filter { | ||
|
|
||
| @Override | ||
| public Response filter(FilterableRequestSpecification requestSpec, FilterableResponseSpecification responseSpec, FilterContext ctx) { |
Collaborator
There was a problem hiding this comment.
check if this is added to the data module. It will be useful there
n1xan
reviewed
Aug 5, 2025
|
|
||
| import static com.google.gson.FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES; | ||
|
|
||
| public class EntityDeleterRepository { |
Collaborator
There was a problem hiding this comment.
is htis using the data module?
n1xan
reviewed
Aug 5, 2025
| import static com.google.gson.FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES; | ||
|
|
||
| @SuppressWarnings("UnnecessaryLocalVariable") | ||
| public abstract class HttpRepository<TEntity extends ApiEntity, TEntities extends Entities<TEntity>> { |
Collaborator
There was a problem hiding this comment.
this should also be part of the data module - remove if not needed
n1xan
reviewed
Aug 5, 2025
| import java.util.List; | ||
|
|
||
| @SuppressWarnings("UnnecessaryLocalVariable") | ||
| public abstract class TableApiRepository<TEntity extends ApiEntity, TEntities extends Entities<TEntity>> extends HttpRepository<TEntity, TEntities> { |
Collaborator
Author
There was a problem hiding this comment.
the old class TableApiRepository updated using data module
n1xan
reviewed
Aug 5, 2025
| return typeAdapters; | ||
| } | ||
|
|
||
| public static LinkedHashMap<Type, Object> allExceptEntities() { |
Collaborator
There was a problem hiding this comment.
these should be added to the data module
Collaborator
Author
There was a problem hiding this comment.
new typeAdapters package added
n1xan
reviewed
Aug 5, 2025
| public class RepositoriesMap { | ||
| public static Map<Class<? extends ApiEntity>, Class<? extends TableApiRepository<?, ?>>> realEstateRepos() { | ||
| var map = new HashMap<Class<? extends ApiEntity>, Class<? extends TableApiRepository<?, ?>>>(); | ||
| // The following Code Will be used when need to use MassiveDataDeleter |
Collaborator
There was a problem hiding this comment.
remove all commented repos and chech the whole project for left over project code
Collaborator
Author
There was a problem hiding this comment.
Can not be used with the new TableApiRepository setup.
n1xan
reviewed
Aug 5, 2025
|
|
||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| public class ServiceNowPage extends WebPage<Map, Asserts> { |
Collaborator
There was a problem hiding this comment.
rename the package to match the page name
n1xan
reviewed
Aug 5, 2025
|
|
||
|
|
||
|
|
||
| public class ServiceNowTableViewPage extends WebPage<Map, Asserts> { |
Collaborator
There was a problem hiding this comment.
update the package name to match the class
n1xan
reviewed
Aug 5, 2025
| } | ||
| ] | ||
| }, | ||
| "serviceNowProjectSettings": { |
Collaborator
There was a problem hiding this comment.
remove on a commit and keep the read data checked out only locally
added 4 commits
August 7, 2025 09:36
# Conflicts: # pom.xml
update getting-started\bellatrix.servicenow
added 3 commits
August 7, 2025 15:41
…dule-initial-setup
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
added 6 commits
August 8, 2025 13:35
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
n1xan
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.