Skip to content

fix(rest-api): reject non-string secrets #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjinks wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

fix(rest-api): reject non-string secrets #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions __tests__/unit-tests/test-rest-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,17 @@ public function test_run_event() {
$this->assertArrayHasKey( 'message', $data );
}

public function test_array_secret_is_rejected() {
$request = new WP_REST_Request( 'POST', '/' . REST_API::API_NAMESPACE . '/' . REST_API::ENDPOINT_LIST );
$request->set_body( wp_json_encode( [ 'secret' => [] ] ) );
$request->set_header( 'content-type', 'application/json' );

$response = $this->server->dispatch( $request );

$this->assertResponseStatus( 400, $response );
$this->assertEquals( 'no-secret', $response->get_data()['code'] );
}

/**
* Check response code
*
Expand Down
2 changes: 1 addition & 1 deletion includes/class-rest-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public function check_secret( $request ) {
$body = $request->get_json_params();

// For now, mimic original plugin's "authentication" method. This needs to be better.
if ( ! isset( $body['secret'] ) || ! hash_equals( \WP_CRON_CONTROL_SECRET, $body['secret'] ) ) {
if ( ! isset( $body['secret'] ) || ! is_string( \WP_CRON_CONTROL_SECRET ) || ! is_string( $body['secret'] ) || ! hash_equals( \WP_CRON_CONTROL_SECRET, $body['secret'] ) ) {
return new \WP_Error(
'no-secret',
__( 'Secret must be specified with all requests', 'automattic-cron-control' ),
Expand Down
Loading