Repository navigation
test(capture): await source resize fixture transitions - #593
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #592. Wait for the fixture's source-owned resize transition before measuring its baseline:
--image-heightvalue matches the authored response at the current width.dataset.pose === 'resized'precondition before checking the original page's 29px pose.All existing height, width, alignment, typography and source-page preservation assertions remain intact. This repairs the test setup boundary exposed by two separate CI attempts on #591.
Verification
npm exec vitest -- run src/lib/screenshot/fluid-capture.test.ts src/lib/fidelity/reference.test.ts --maxWorkers=2. The retained proof driver runs withnode --import tsx dla-resize-fixture-proof.mts.184ce586f327604e07291079a3bc8da4fb2e84fe3d34369eff6e90d909aa2584.Full authoritative CI is the shipping gate. Once this independent repair ships, #591 resumes through it.
AI assistance / execution provenance
OpenAI
openai/gpt-6.1-solthrough OpenCode diagnosed the CI failures, implemented the readiness waits, ran delayed-delivery and browser verification and drafted this PR under Chris Huber's direction. Direct execution and finalization outside Homeboy are operator-authorized; retained session evidence is linked to #592 and the blocked #591 run.