Subscribe Block: enable customizing the button-only pop-up via the editor - #51255
Subscribe Block: enable customizing the button-only pop-up via the editor#51255gabrielcaires wants to merge 1 commit into
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
…itor The "Button only" Subscribe block style renders no visible email input, so it opened the subscribe.wordpress.com checkout iframe with an empty email, which then had to ask for it inside the iframe itself. Every other style avoids this by collecting email inline first. Add Jetpack_Subscribe_Modal_Button, a local pop-up mirroring Jetpack_Subscribe_Modal's existing pattern (editable Site Editor template part, no settings field). Clicking a "Button only" block now opens this pop-up first; submitting its own embedded Subscribe block hands off to checkout as before, this time with email populated. Replace the "Subscribe modal heading" settings field with a 5th entry in the existing Subscriptions placements grid, consistent with the other pop-ups it sits alongside.
4258d58 to
6e2aa27
Compare
Fixes #
Proposed changes
Jetpack_Subscribe_Modal_Button, a local pop-up shown when a visitor clicks a "Button only" style Subscribe block, mirroringJetpack_Subscribe_Modal's existing pattern (editable Site Editor template part, no separate settings field).subscribe_modal_headingsite option, so a site that already customized it doesn't lose that text.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
subscribe.wordpress.com/memberships) should now open with the email already populated, skipping straight to plan selection/thanks (not asking for email again).jetpack-subscribe-modal-buttontemplate part in the Site Editor.🤖 Generated with Claude Code