Skip to content

tools: Handle empty list in cleanup-excludelists.sh - #51256

Merged
anomiex merged 1 commit into
trunkfrom
fix/cleanup-excludelists-empty-list
Aug 13, 2026
Merged

tools: Handle empty list in cleanup-excludelists.sh#51256
anomiex merged 1 commit into
trunkfrom
fix/cleanup-excludelists-empty-list

Conversation

@anomiex

@anomiex anomiex commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

If an exclude list is empty, the script would lint everything (and try to add anything failing to the list) instead of linting nothing. Add checks for this situation.

Related product discussion/links

#50989 (review)

Does this pull request change what data or activity we track or use?

No

Testing instructions

  • Check that the script didn't run eslint over the whole monorepo.

If an exclude list is empty, the script would lint everything (and try
to add anything failing to the list) instead of linting nothing. Add
checks for this situation.
@anomiex anomiex self-assigned this Aug 13, 2026
@anomiex
anomiex requested a review from a team as a code owner August 13, 2026 16:30
@anomiex anomiex added [Status] Needs Review This PR is ready for review. [Pri] Normal labels Aug 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@anomiex
anomiex merged commit fe71da4 into trunk Aug 13, 2026
76 of 77 checks passed
@anomiex
anomiex deleted the fix/cleanup-excludelists-empty-list branch August 13, 2026 16:58
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant