[Homebrew/Security] Accept reviewed native build requirements during bottle publication - #1085
Conversation
Treat exact static Requirement declarations as references into the already-bound Formula support tree instead of rejecting every additional support-module token. Keep authority over Requirement classes, tags, AST placement, and support definitions in the Ripper parser, and cover the exact Asa shape plus dynamic-reference rejection in the publication contract.
|
CI status is understood:
The tap trust rotation is now merged, and fresh Asa-only run |
|
Live canary evidence is now complete for exact head
The controller stopped before the parallel wave on a separate tap-side continuation issue: aggregate metadata correctly rolled over to the current ABI42-only catalog, while the controller still looked there instead of at durable per-Formula sidecars for implicit versions. No wave dispatch occurred; that general controller fix is being handled separately in the tap. |
Why
Asa uses two reviewed native build tools from the tap's sealed Formula support code. The post-build source check counted every
KandeloFormulaSupportreference and therefore mistook those ordinary requirement declarations for extra source loading. Asa built and tested successfully, but publication stopped before uploading anything.What changes
depends_on KandeloFormulaSupport::<Name>Requirement => <literal tags>source shape as a reference into the support tree that is already part of the verified source closure.KandeloFormulaSupport.const_get(...), extra source loaders, extraTap.fetchcalls, andrequire_relative.:buildplus[:build, :test]shape and the dynamic-reference failure case.Validation
bash scripts/dev-shell.sh bash scripts/test-homebrew-publish-workflow.shbash -n scripts/homebrew-validate-formula-source-closure.sh scripts/test-homebrew-oci-layout.sh scripts/test-homebrew-publish-workflow.shgit diff --checkThis PR is stacked on #1084. The next proof is the exact Ubuntu preflight, followed by a one-package Asa canary before any parallel rollout.