Make Coreutils runtime aliases match built programs - #878
Closed
brandonpayton wants to merge 1 commit into
Closed
Conversation
Build the declared Coreutils 9.6 source from version-keyed state, rerun configure so recipe changes cannot reuse stale member lists, explicitly include arch, and expose the built kill member through shared runtime and rootfs aliases. Remove image-local lists that mapped unsupported names to the multicall binary, declare Coreutils and source inputs for MariaDB VFS consumers, and bump every affected package revision.
Contributor
Phase B-1 matrix build status —
|
| Package | Arch | Status | Sha |
|---|---|---|---|
| coreutils | wasm32 | failed | — |
| mariadb-test | wasm32 | failed | — |
| mariadb-vfs | wasm32 | failed | — |
| mariadb-vfs | wasm64 | failed | — |
| rootfs | wasm32 | failed | — |
| shell | wasm32 | failed | — |
| lamp | wasm32 | failed | — |
| node-vfs | wasm32 | failed | — |
| wordpress | wasm32 | failed | — |
Auto-generated; replaced on each push. Raw data in the publish-status workflow artifact.
Member
Author
|
Closing because Coreutils build ownership and installed command links are moving to the Homebrew Formula and generated Kandelo sidecars in kandelo-dev/homebrew-tap-core. The correctness requirements here remain important: enable the intended members, include kill, and never advertise false aliases. Those requirements should be carried into the Formula and Homebrew VFS acceptance tests. The branch and PR history are retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make the Coreutils package's built multicall members, runtime command maps, and rootfs aliases describe the same executable surface.
The registry previously built a default Coreutils 9.5 source tree despite declaring 9.6, exposed
archeven though upstream excludes it unless explicitly enabled, and omitted the already-builtkillmember. Several VFS builders also mapped non-Coreutils names such ashostname,rev,hexdump,xxd, andsedto the Coreutils binary, which could only fail at argv0 dispatch.Changes
--without-libgmpoption, and explicitly enable the normally opt-inarchprogram.killto the canonical 101-member Coreutils command list and to rootfs aliases.archandkillargv0 dispatch in the package runtime suite.No kernel/host ABI surface changes in this PR.
Validation
Run through
scripts/dev-shell.sh:coreutils-srctree was ignored in favor of a newcoreutils-9.6-srctree._start,__abi_version, and all fivewpk_fork_*continuation functions, and contains no legacy Asyncify marker./bin/archand/bin/killexecution through dash's alias/exec path.[dispatched withoutunknown program./bin/kill --versionexecuted GNU Coreutils 9.6; removed false alias/bin/hostnametruthfully returned 127/not found.archreturnedwasm32,kill --versionidentified the correct member,falsereturned 1, andprintfreturned exact formatted output.build-deps parserecognizedcoreutils@9.6for both MariaDB packages andbuild-deps checkpassed.bash -n, focused Prettier, structured TOML parsing for all changed manifests, Git whitespace checks, andscripts/check-abi-version.shpassed.scripts/ci-check-browser-assets.shwas attempted but could not complete in the isolated integration worktree because 82 unrelated package binaries were not materialized. The focused Chromium page had all of its imports and passed. Full downstream rootfs/MariaDB/SQLite image rebuilds were not run locally; their revisions are bumped for CI rebuilds.Current CI status
Browser smoke, change-scope, preflight, and toolchain-cache checks are green. The Coreutils staging build on current
mainreaches compilation and fails in gnulibstrftime.con unknowntimezone_tand undeclaredmktime_z; this is the exact SDK target-facts gap fixed by #874. The package does not duplicate those platform facts locally. Re-run staging after #874 lands.Build gates