libxml2: preserve resolver zlib inputs in manual build - #901
Closed
brandonpayton wants to merge 1 commit into
Closed
libxml2: preserve resolver zlib inputs in manual build#901brandonpayton wants to merge 1 commit into
brandonpayton wants to merge 1 commit into
Conversation
Member
Author
|
Exact-head CI classification for
Failing job: https://github.com/Automattic/kandelo/actions/runs/29195911562/job/86660143205 No broader green claim is made while the required check remains red. |
Member
Author
|
Merged PR #907 supersedes this work through the holistic libxml2 resolver-input correction now on main at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Keep libxml2's manual source build on the package resolver's declared zlib dependency path.
The build script runs configure with
--with-zlib, then bypasses the generated Makefiles and compiles the libxml2 sources itself. That manual compile omitted the resolver zlib include directory, so CI failed attree.c: fatal error: zlib.h: No such file or directoryeven though the resolver had supplied a complete zlib prefix.Change
This changes package build behavior only. It does not change the Kandelo ABI.
Validation
All commands ran through
scripts/dev-shell.sh.bash -n packages/registry/libxml2/build-libxml2.shlib/libxml2.azlib.handgzread in -lz, then producedlib/libxml2.axmlReadMemoryandzlibVersionagainst resolver-produced libxml2 and zlib prefixeswasm-validate --enable-threads --enable-exceptions --enable-function-referenceson the smoke modulegit diff --checkshellcheckwas not run because it is not available in the declared dev shell.