CI: retry verified staged release downloads - #939
Conversation
3513b92 to
2e12030
Compare
|
Independent exact-head review: accepted at The review initially found that release-derived values were interpolated directly into shell source. That was fixed before this head by moving No blocking correctness or security findings remain. The reviewer independently passed Bash syntax, all 12 focused fixture assertions, |
|
CI diagnosis for exact head
No source-build fallback or cache bypass will be added. Once #913 merges, I will rebase #939 onto the resulting |
2e12030 to
4e3d19c
Compare
Package promotion currently fails an entire prepare-merge run when a single GitHub release read transiently reports that an existing staging release is missing. Retry exact asset downloads in private attempt directories and publish only a complete archive into the promotion directory. Add focused fixture coverage for transient and permanent failures, partial files, exact arguments, and unsafe input.
4e3d19c to
52d30d5
Compare
|
Absorbed by rebase-merged #967. Main is now 6efb411 with the sealed tree b133bfa018f7e2bc84c4845edf2f945b2f844954, and ABI 41 activation completed successfully in run 29550069085. The absorption audit confirmed this PR\x27s behavior and tests are present in that merged tree, so this source PR is closed and its branch is deleted. |
Why
prepare-mergepreviously attempted each staged archive download only once. A temporary GitHub release read could therefore fail an otherwise valid package promotion even when the immutable release and asset still existed.This happened on PR #913: one libxml2 download reported
release not found, while 70 sibling downloads succeeded and an unchanged retry later passed.What changed
This changes package release controls only. It does not change Kandelo runtime behavior, ABI, package recipes, archives, or indexes.
Validation
Run through
scripts/dev-shell.shon exact commit52d30d5c75ce8b5a8781a9d4e7f90b2986120fb5/ tree7eb9754b1b26f6b406154e4b0366449281cd8964:git diff --checkpassed;tests/scripts/package-publish-flow.shsuite passed.The rebased commit has the same stable patch ID as the previously reviewed head. Independent devil advocate review approved this exact commit with no findings.
Merge
This PR receives standalone hosted validation because it changes archive-promotion release controls. It has no dependency on batch infrastructure. Merge only after the refreshed exact-head checks are green.