fix(search): remove duplicate search form on no-results page

[faisalahammad]

Summary

When a search returns no results, the page renders two identical search forms — one in the page header (search.php:19) and another in the content area (content-none.php:39). Remove the duplicate from the content area since the header form is already visible.

Fixes #1796

Changes

newspack-theme/template-parts/content/content-none.php

Before:

elseif ( is_search() ) :
    ?>
    <p><?php esc_html_e( 'Sorry, but nothing matched your search terms. Please try again with some different keywords.', 'newspack-theme' ); ?></p>
    <?php
    get_search_form();

else :

After:

elseif ( is_search() ) :
    ?>
    <p><?php esc_html_e( 'Sorry, but nothing matched your search terms. Please try again with some different keywords.', 'newspack-theme' ); ?></p>
    <?php

else :

Why: The search results page already has a search form in its header. The else branch (used by 404 pages and empty archives) retains its search form since those pages don't have one elsewhere.

Testing

Test 1: Search with no results

1. Search for a term that returns nothing (e.g., ?s=xyznonexistent123)
2. Verify only one search form appears (in the page header)

Test 2: 404 page

1. Visit a nonexistent URL
2. Verify the search form still appears in the content area

Test 3: Empty archive

1. Visit a category with no posts
2. Verify the search form still appears in the content area

Screenshot