fix: use activity window for status bar icons in dialog fragments - #5704
Open
ibrahim-iqbal wants to merge 1 commit into
Open
fix: use activity window for status bar icons in dialog fragments#5704ibrahim-iqbal wants to merge 1 commit into
ibrahim-iqbal wants to merge 1 commit into
Conversation
BaseDialogFragment was setting status bar icon appearance on the dialog's own window, which has no effect on the actual status bar. Use the activity's window instead, matching BaseAppCompatDialogFragment. Fixes Automattic#2127
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseDialogFragment.onViewCreated()was callingtheme.updateWindowStatusBarIcons()ondialog?.window, but status bar icon appearance is controlled by the activity's window, not the dialog's overlay windowactivity?.windowfor status bar icons, matching howBaseAppCompatDialogFragmentalready handles this correctlyFixes #2127
Test plan