feat(pr-review): let rework agent skip non-actionable bot comments via skip file#124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
ignored_reviewers(PR #122) silences whole bot accounts, but a review bot can post both actionable and non-actionable comments. The rework agent should be able to skip a single clearly non-actionable bot comment without silencing the account.TL;DR
Let the rework agent mark individual non-actionable bot comments to skip, so they get no auto-reply — humans are never skippable.
Summary
.symphony-skip-comments.jsoninstead of replying (path d); never for human reviewers.Alternatives
reply_after_addressingso the agent owns all replies: rejected, loses the actionable-reply safety net.ignored_reviewers: rejected, it is per-account and cannot skip one comment from an otherwise-actionable bot.Test Plan
make allmix format --check-formatted,mix specs.check,mix credoon changed files.