Conversation
…t wrap it in <p> The webpack production build wraps inline MDX (<span> badge, Callout text) in <p>, inheriting the p override's my-4 margin and inflating it; Turbopack dev keeps it inline so it only broke on prod. Move the badge to a Badge component and harden the Callout guard with [&_p]:my-0!.
…ne JSX The webpack production build (Vercel) renders inline JSX in MDX prose as block elements: a raw <span> badge wrapped its text in <p>, and inline <Link> split sentences into [P, A, P]. Turbopack dev kept them inline, so it only broke on prod. CSS margin guards can't fix a block-split. - Convert every inline <Link> in the docs MDX to markdown links, which are inline by MDX spec and immune to the JSX-flow heuristic. - Route the mdx-components `a` override through next/link for internal hrefs (client-side nav) and <a target=_blank> for external. - Render the "Recommended" badge as a Badge component so its text is never re-parsed into a <p>; harden the Callout guard with [&_p]:my-0!.
…orcement, fix all findings
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.