fix: CRS tests work without compressed data on disk#22066
Merged
johnathan79717 merged 2 commits intomerge-train/barretenbergfrom Mar 26, 2026
Merged
fix: CRS tests work without compressed data on disk#22066johnathan79717 merged 2 commits intomerge-train/barretenbergfrom
johnathan79717 merged 2 commits intomerge-train/barretenbergfrom
Conversation
- check_bn254_consistency uses get_bn254_g1_data which handles both compressed and uncompressed formats automatically - Chunk hash tests download compressed data from CDN inline instead of reading from disk, so they work regardless of local cache state
Default mode is now happy if either compressed or uncompressed CRS exists on disk. If neither exists, downloads compressed (smaller). CRS_FORMAT=uncompressed downloads uncompressed and deletes compressed, used for AMI baking where we want fast cold starts. Update ami_update.sh to use CRS_FORMAT=uncompressed.
johnathan79717
requested review from
ludamad
and removed request for
charlielye
johnathan79717
added
ci-full
ludamad
approved these changes
Mar 26, 2026
johnathan79717
added
ci-barretenberg
johnathan79717
merged commit e7fc502
into
merge-train/barretenberg
49 of 58 checks passed
notnotraju
pushed a commit
that referenced
this pull request
Mar 26, 2026
## Summary - CRS factory tests no longer require `bn254_g1_compressed.dat` on disk. `check_bn254_consistency` uses `get_bn254_g1_data()` which handles both formats. Chunk hash tests download directly from CDN inline. - `crs/bootstrap.sh` gains a `CRS_FORMAT` mode: default is happy if either compressed or uncompressed exists; `CRS_FORMAT=uncompressed` downloads uncompressed and deletes compressed (for AMI baking). - `ami_update.sh` uses `CRS_FORMAT=uncompressed` so AMI instances have uncompressed CRS for fast cold starts. ## Test plan - [x] `srs_tests` builds and passes locally - [ ] CI passes with `ci-barretenberg` label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bn254_g1_compressed.daton disk.check_bn254_consistencyusesget_bn254_g1_data()which handles both formats. Chunk hash tests download directly from CDN inline.crs/bootstrap.shgains aCRS_FORMATmode: default is happy if either compressed or uncompressed exists;CRS_FORMAT=uncompresseddownloads uncompressed and deletes compressed (for AMI baking).ami_update.shusesCRS_FORMAT=uncompressedso AMI instances have uncompressed CRS for fast cold starts.Test plan
srs_testsbuilds and passes locallyci-barretenberglabel