feat: add Cosmos DB NoSQL create-index samples (Python, Go) and shared infra#88
Open
diberry wants to merge 4 commits into
Open
feat: add Cosmos DB NoSQL create-index samples (Python, Go) and shared infra#88diberry wants to merge 4 commits into
diberry wants to merge 4 commits into
Conversation
- Add reusable vector-containers.bicep module (DiskANN + QuantizedFlat) - Add conditional HotelsCreateIndex database in infra - Add Python sample (nosql-create-index-python/) - Add Go sample (nosql-create-index-go/) - Add *.exe to .gitignore Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
Review Score: 15/16 [PASS]
Strengths
Minor IssueBicep partition key inconsistency: Line 49 uses /HotelId but line 73 uses /PartitionKey. Should standardize. RecommendationAPPROVE — Ready to merge. Operationally sound with excellent code quality, error handling, and documentation. |
Use @TopK query parameter instead of string interpolation for the TOP clause, aligning with cosmosdb-agent-kit sdk-best-practices rule query-top-literal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Report failed document count and raise RuntimeError when batch operations return non-success status codes, instead of silently counting only successes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
Review: UNANIMOUS APPROVAL ✅All 8 specialist reviewers approved.
Rounds needed: 2. Fix: Python ingestion now raises RuntimeError on partial batch failures. |
- Python article: transactional batch inserts, azure-cosmos SDK, DefaultAzureCredential - Go article: concurrent goroutine inserts, azcosmos SDK, semaphore pattern - Both articles passed 8-agent unanimous approval review (3 rounds) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the shared infrastructure and first two language ports for the Cosmos DB for NoSQL create-index scenario.
Highlights:
DiskANN+QuantizedFlat)HotelsCreateIndexdatabase wiring in infra.gitignoreupdate for generated*.exeartifactsSee Design concept.
New directories/files
New directories
nosql-create-index-python/nosql-create-index-go/New shared infra file
infra/cosmos-db/nosql/vector-containers.bicepUpdated infra/support files
infra/database.bicepinfra/main.bicep.gitignoreReview status
Rollout context
This is Wave 1 of a 4-language create-index effort.
Design concept
This implementation follows the two key design constraints for the create-index rollout:
HotelsCreateIndexdatabase for the new immutable container shape.