Update infra: gpt-4.1 models, AVM versions, secure password

[diberry]

Changes

• Model updates: Upgraded to gpt-4.1 models
• AVM version bumps: Updated Azure Verified Module versions to latest
• API version: Updated to current API version
• Secure password: Replaced hardcoded password with secure generated password

[diberry]

🔄 Squad Review — PR #59 (Infra Update - gpt-4.1 Models)

Reviewers: Drummer (Tech Review), Amos (Sample Dev)

⚠️ Approved with finding

Drummer (Tech Reviewer):

• ✅ Model updates: gpt-4o-mini → gpt-4.1-mini, gpt-4o → gpt-4.1 — correct upgrade path
• ✅ AVM version bumps: managed-identity 0.4.0 → 0.5.0, cognitive-services 0.7.1 → 0.14.0 — good maintenance
• ✅ API version: Updated to 2025-04-01-preview — current
• ⚠️ Password handling: documentDbAdminPassword changed from hardcoded TempP@ssw0rd123! to readEnvironmentVariable('DOCUMENTDB_ADMIN_PASSWORD', ''). The empty string default means deployment will fail if the env var isn't set. Consider:
  • Adding validation in the template, OR
  • Documenting the required env var in README/sample.env, OR
  • Using @secure() with minLength constraint

Amos (Sample Dev):

• ✅ Good security improvement removing hardcoded password
• ⚠️ Need to ensure azd workflow sets DOCUMENTDB_ADMIN_PASSWORD — check azure.yaml or azd env set docs

Verdict: squad:pr-reviewed ✅

Small, focused, and correct. Minor concern about empty password default. Awaiting squad:pr-dina-approved before merge.

[diberry]

📊 Squad Status — PR Review

Ralph (Work Monitor) — sweep on 2026-03-31

Review Pipeline Status

• ✅ squad:pr-reviewed — Squad review complete
• ⏳ Awaiting squad:pr-dina-approved — Dina must review and approve before merge

Next Steps

1. Dina reviews this PR
2. If approved, Dina adds squad:pr-dina-approved label
3. Ralph merges after Dina's approval

⚠️ Will NOT merge without Dina's explicit approval.

[diberry]

Superseded by #70 which includes all changes from this PR (AVM bumps, API version upgrades, secure password) plus configurable OpenAI params, separate location, README documentation, and vector index notes.