fix(acm): pin governance policy propagator image - #6827
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The PR description does not currently reference a tracking ticket/issue as required by CONTRIBUTING.md.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR pins the ACM governance-policy-propagator workload to a specific image digest via the multicluster-engine-config parent chart values, while leaving other policy component images to continue being derived from the ACM operator bundle defaults.
Changes:
- Add
global.imageOverrides.governance_policy_propagatorto override the propagator image digest used by the policy subchart templates.
File summaries
| File | Description |
|---|---|
| acm/multicluster-engine-config.values.yaml | Adds a per-component image override for governance_policy_propagator while retaining the existing registry override. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The PR description does not reference a tracking ticket/issue as required by CONTRIBUTING.md Pull Request Standards (§4).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
32f404a to
0dfc446
Compare
0dfc446 to
f546f6c
Compare
f546f6c to
1f419dd
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to a single Helm image override and corresponding fixture update, with no security-sensitive or CI/pipeline-impacting modifications.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
/unhold |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avollmer-redhat, mmazur, roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://redhat.atlassian.net/browse/AROSLSRE-2029
Why
Temporarily pin the governance policy propagator workload to the requested digest while retaining bundle-derived defaults for the other ACM policy components. The image is consumed through the fixed SVC ACR cache repository introduced by #6829.
Dependency and rollout order
This PR is blocked by #6829. PR checks deploy the Region entrypoint but do not deploy Global infrastructure, so merely adding the cache rule in a PR does not make it available to E2E.
Microsoft.Azure.ARO.HCP.Globalentrypoint so the cache rule reaches all SVC ACRs, including the shared development ACR used by PR checks.Production rollout must preserve the same Global-before-Region ordering. This PR remains draft until the cache PR is merged and the Global deployment completes.
Validation
make update-helm-fixturesmake yamlfmtmake test-helm-fixturesgit diff --check