Skip to content

fix(acm): pin governance policy propagator image - #6827

Merged
openshift-merge-bot[bot] merged 1 commit into
Azure:mainfrom
mmazur:pin-governance-policy-propagator
Sep 8, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
Azure:mainfrom
mmazur:pin-governance-policy-propagator

Conversation

@mmazur

@mmazur Mariusz Mazur (mmazur) commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

https://redhat.atlassian.net/browse/AROSLSRE-2029

Why

Temporarily pin the governance policy propagator workload to the requested digest while retaining bundle-derived defaults for the other ACM policy components. The image is consumed through the fixed SVC ACR cache repository introduced by #6829.

Dependency and rollout order

This PR is blocked by #6829. PR checks deploy the Region entrypoint but do not deploy Global infrastructure, so merely adding the cache rule in a PR does not make it available to E2E.

  1. Merge fix(acr): cache governance policy propagator image #6829.
  2. Deploy the Microsoft.Azure.ARO.HCP.Global entrypoint so the cache rule reaches all SVC ACRs, including the shared development ACR used by PR checks.
  3. Retry E2E on this PR.
  4. Mark this PR ready after E2E passes.

Production rollout must preserve the same Global-before-Region ordering. This PR remains draft until the cache PR is merged and the Global deployment completes.

Validation

  • make update-helm-fixtures
  • make yamlfmt
  • make test-helm-fixtures
  • git diff --check

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR description does not currently reference a tracking ticket/issue as required by CONTRIBUTING.md.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR pins the ACM governance-policy-propagator workload to a specific image digest via the multicluster-engine-config parent chart values, while leaving other policy component images to continue being derived from the ACM operator bundle defaults.

Changes:

  • Add global.imageOverrides.governance_policy_propagator to override the propagator image digest used by the policy subchart templates.
File summaries
File Description
acm/multicluster-engine-config.values.yaml Adds a per-component image override for governance_policy_propagator while retaining the existing registry override.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread acm/multicluster-engine-config.values.yaml Outdated
Copilot AI review requested due to automatic review settings September 4, 2026 10:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR description does not reference a tracking ticket/issue as required by CONTRIBUTING.md Pull Request Standards (§4).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@mmazur
Mariusz Mazur (mmazur) force-pushed the pin-governance-policy-propagator branch from 32f404a to 0dfc446 Compare September 4, 2026 12:20
Copilot AI review requested due to automatic review settings September 4, 2026 12:20
@mmazur
Mariusz Mazur (mmazur) force-pushed the pin-governance-policy-propagator branch from 0dfc446 to f546f6c Compare September 4, 2026 12:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped to a single Helm image override and corresponding fixture update, with no security-sensitive or CI/pipeline-impacting modifications.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@mmazur

Copy link
Copy Markdown
Collaborator Author

/unhold
/retest

@roivaz

Copy link
Copy Markdown
Collaborator

/lgtm

@avollmer-redhat

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avollmer-redhat, mmazur, roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit c3adceb into Azure:main Sep 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants