Skip to content

Respect --cloud in publish pre-flight checks - #281

Merged
Alexander Zaslonov (azaslonov) merged 2 commits into
mainfrom
copilot/fix-publish-cloud-flag
Sep 12, 2026
Merged

Respect --cloud in publish pre-flight checks#281
Alexander Zaslonov (azaslonov) merged 2 commits into
mainfrom
copilot/fix-publish-cloud-flag

Conversation

Copilot AI commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

apiops publish --cloud usgov checked resource-group existence against Azure’s public endpoint, causing false “resource group not found” errors despite correct cloud configuration.

  • Endpoint selection: Derive the resource-group check’s ARM origin from the configured service URL, preserving path encoding and API versions.
  • Regression coverage: Verify both pre-flight requests use the selected endpoint for public, US Government, China, and Germany clouds.

Copilot AI balanced review requested due to automatic review settings September 12, 2026 00:13
Copilot AI reviewed Sep 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI linked an issue Sep 12, 2026 that may be closed by this pull request
Publish does not respect --cloud flag #230
Closed
@azaslonov
fix: respect cloud endpoint in publish pre-flight checks (Closes #230)
7d191d6 
Co-authored-by: azaslonov <2320302+azaslonov@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 12, 2026 00:16
Copilot AI reviewed Sep 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The implementation appears correct, but the PR explicitly leaves tests, lint, build, and security validation pending.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Copilot AI changed the title [WIP] Fix publish command to respect --cloud flag Respect --cloud in publish pre-flight checks Sep 12, 2026
@azaslonov
Alexander Zaslonov (azaslonov) marked this pull request as ready for review September 12, 2026 00:35
@azaslonov
Alexander Zaslonov (azaslonov) merged commit 5e1dd93 into main Sep 12, 2026
7 checks passed
@azaslonov
Alexander Zaslonov (azaslonov) deleted the copilot/fix-publish-cloud-flag branch September 12, 2026 00:37
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@atuannguyen1101 Tuan Nguyen (atuannguyen1101) atuannguyen1101 approved these changes
+1 more reviewer
@azaslonov Alexander Zaslonov (azaslonov) azaslonov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@azaslonov Alexander Zaslonov (azaslonov)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Publish does not respect --cloud flag

4 participants

@azaslonov @atuannguyen1101