Expand ECC generate key tests

[meilu-git]

No description provided.

[Copilot]

Pull request overview

Expands the TBOR EccGenerateKey emulator integration tests to cover additional lifecycle/authorization scenarios and negative-path validation, strengthening confidence in ECC key generation behavior across curves and scopes.

Changes:

• Extend key generation coverage to assert fresh generation on repeated calls for each supported NIST curve.
• Add tests for scope lifecycle rules (Session allowed pre-finalize; Ephemeral rejected pre-finalize; SecurityDomain rejected before SD creation).
• Add negative-path tests for invalid curve/scope discriminants and mismatched session identifiers, plus a CU-session authorization test (with PSK rotation to avoid default-PSK gating).

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (3)

ddi/tbor/types/tests/commands/ecc_generate_key.rs:174

• This test opens a rotated CO session via bootstrap_rotated_co, but never closes it. Since the emulator session table is process-global, leaking the session can impact later tests. Consider wrapping the handshake in SessionGuard and using session.session_id() in the request.

    let session = bootstrap_rotated_co(&ctx, &ROTATED_CO_PSK);
    ctx.expect_fw_reject(
        &TborEccGenerateKeyReq {
            session_id: session.session_id,
            scope: SCOPE_EPHEMERAL,

ddi/tbor/types/tests/commands/ecc_generate_key.rs:121

• bootstrap_rotated_co returns a raw SessionHandshake and this test never closes the resulting session. The harness documents that leaked emulator session slots persist across serial tests, so this can cause cross-test failures. Wrap the handshake in SessionGuard so the session is reliably closed on drop.

This issue also appears on line 170 of the same file.

    let session = bootstrap_rotated_co(&ctx, &ROTATED_CO_PSK);
    generate(&ctx, session.session_id, SCOPE_SESSION, ECC_CURVE_P256);

ddi/tbor/types/tests/commands/ecc_generate_key.rs:145

• The CU session opened via session_open_init_with_options / session_open_finish is never closed. The harness provides SessionGuard specifically to prevent leaked emulator session slots from breaking subsequent tests; wrapping the returned SessionHandshake would make this panic-safe.

    let session = ctx
        .session_open_finish(pending)
        .expect("finish CU session open");

    generate(&ctx, session.session_id, SCOPE_SESSION, ECC_CURVE_P256);

[Rajesh Gali (rajesh-gali)]

these variables can common, please check if we can use common location to use the constants

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.