tbor tests ecc sign - #670
Open
meilu-git wants to merge 5 commits into
Open
Conversation
meilu-git
requested review from
Rajesh Gali (rajesh-gali)
and
a lite review from Copilot
August 24, 2026 18:02
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the TBOR EccSign integration test coverage by adding additional positive/negative-path cases and making the core ECC sign round-trip tests runnable outside of the emu feature where applicable.
Changes:
- Added helpers for generating keys under a specified scope and for issuing
EccSignrequests. - Added new tests covering multiple digest-length pairings, digest mismatch rejection, P-521 padding invariants, tampered masked-key rejection, and unknown-session rejection.
- Switched several tests to use
bootstrap_rotated_coso they can run in non-emuconfigurations where supported.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Rajesh Gali (rajesh-gali)
changed the title
Rajesh Gali (rajesh-gali)
requested changes
Aug 28, 2026
meilu-git
force-pushed
the
meilu/tbor_tests_ecc_sign
branch
from
August 31, 2026 15:57
500d241 to
ecb4bba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.