test(tbor): expand get cert chain info coverage - #674
Open
meilu-git wants to merge 2 commits into
Open
Conversation
meilu-git
requested review from
Rajesh Gali (rajesh-gali)
and
a lite review from Copilot
August 27, 2026 02:23
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the integration test coverage for the out-of-session TBOR GetCertChainInfo command, adding additional behavioral assertions around certificate bounds, stability, and interactions with unrelated session activity.
Changes:
- Add tests that validate
num_certsdefines the validGetCertificateindex range and that each advertised certificate is readable. - Add stability tests ensuring certificate reads, invalid-slot requests, and unrelated session activity do not mutate
GetCertChainInforesults. - Broaden invalid-slot coverage (including boundary slot IDs) and add additional invariants around repeated certificate reads.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
meilu-git
force-pushed
the
test/get-cert-chain-info-coverage
branch
from
August 31, 2026 16:52
52d47a0 to
bf300da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.