Test/get cert coverage - #690
Open
meilu-git wants to merge 2 commits into
Open
Conversation
meilu-git
requested review from
Rajesh Gali (rajesh-gali)
and
a lite review from Copilot
September 1, 2026 18:39
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the TBOR GetCertificate integration test suite in ddi/tbor/types to improve behavioral coverage and cross-check correctness against MBOR and session lifecycle interactions.
Changes:
- Adds DER wire-limit and X.509 parsing validation for certificates returned by TBOR
GetCertificate. - Introduces additional stability and invariance tests (repeat reads, interleaved reads, session-active behavior, reject-path non-mutation).
- Broadens negative-coverage for invalid indices/slots and validates boundaries against
GetCertChainInfo.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.