Enable SD Sealing keygen tests on hardware - #692
Conversation
Abhijit Nathwani (msft-nathwania)
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to enabling an existing test module for hardware runs and only updates compile gating and test names without altering test logic.
Pull request overview
This PR makes the SdSealingKeyGen TBOR integration tests run in the non-emu (hardware-eligible) backend regime by removing the file-level #![cfg(feature = "emu")] gate and normalizing test names to no longer imply emulator-only coverage.
Changes:
- Remove
emu-only compile gate fromsd_sealing_key_gencommand tests so they can run on hardware/no-backend-feature builds. - Rename the affected test functions to drop the
_emusuffix.
File summaries
| File | Description |
|---|---|
| ddi/tbor/types/tests/commands/sd_sealing_key_gen.rs | Removes emu-only gating and renames tests so the SdSealingKeyGen coverage runs in hardware-eligible configurations. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
🟢 Approval recommended
The change is limited to lifting an emu-only compile gate and renaming tests, with no functional logic changes to the test behavior.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
Preserve the SD sealing-key transport documentation while incorporating main's independent hardware enablement in #692 and subsequent changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b6e9403d-692c-4903-97ee-87f2606151c3
No description provided.