Gate hw-unsupported commands behind emu - #693
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change aligns with existing test-suite patterns for emu-only command coverage and is a minimal, low-risk gating adjustment.
Pull request overview
This PR gates TBOR integration tests for GetCertificate and GetCertChainInfo behind the emu feature so they do not compile/run in non-emulator test regimes (e.g., real-silicon runs with no backend feature enabled).
Changes:
- Added
#![cfg(feature = "emu")]at the crate/module level to theget_certtest module. - Added
#![cfg(feature = "emu")]at the crate/module level to theget_cert_chain_infotest module.
File summaries
| File | Description |
|---|---|
| ddi/tbor/types/tests/commands/get_cert.rs | Gates GetCertificate TBOR command integration tests behind the emu feature. |
| ddi/tbor/types/tests/commands/get_cert_chain_info.rs | Gates GetCertChainInfo TBOR command integration tests behind the emu feature. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Wenbo Yuan (wenbo-yuan)
disabled auto-merge
September 3, 2026 03:34
Wenbo Yuan (wenbo-yuan)
enabled auto-merge
September 3, 2026 03:35
Rajib Dutta (radutta99)
approved these changes
Sep 5, 2026
Rajib Dutta (radutta99)
removed this pull request from the merge queue due to a manual request
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.