Add Crypto Engine error codes to HsmError/TborStatus - #697
Open
Aakash Sasidharan (asasidharan) wants to merge 1 commit into
Open
Conversation
Copilot started reviewing on behalf of
Aakash Sasidharan (asasidharan)
September 4, 2026 08:12
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
There is a concrete rustdoc formatting defect in the updated documentation comment, and the new CPT status mapping logic in api/lib is currently untested despite existing unit test coverage in that module.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR extends the AZIHSM error-code surface to directly represent CryptoController (CPT) engine-originated errors across firmware PAL traits (HsmError), the TBOR wire status mirror (TborStatus), and the host API layer, avoiding an extra translation step.
Changes:
- Added the CPT (0x090A_xxxx) error-code range to firmware
HsmErrorand DDITborStatus, preserving numeric values and names. - Added host-facing
HsmErrorvariants and a 1:1DdiError::TborStatus(...) -> HsmErrormapping for the CPT statuses. - Added a firmware-side unit test pinning CPT numeric values to the external source of truth.
File summaries
| File | Description |
|---|---|
| fw/pal/traits/src/error.rs | Adds CPT error variants to FW HsmError and a unit test asserting the numeric values. |
| ddi/tbor/types/src/status.rs | Adds CPT status variants to TborStatus to mirror FW error codes on the wire. |
| api/lib/src/error.rs | Adds host-facing HsmError variants corresponding to CPT statuses. |
| api/lib/src/ddi/mod.rs | Maps CPT TborStatus values 1:1 into host HsmError variants. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+143
to
+147
| DdiError::TborStatus(TborStatus::CryptoNotInitialized) => { | ||
| HsmError::CryptoNotInitialized | ||
| } | ||
| DdiError::TborStatus(TborStatus::CryptoBufferTooSmall) => { | ||
| HsmError::CryptoBufferTooSmall |
| /// All remaining `DdiError` variants are logged and collapsed into | ||
| /// `HsmError::DdiCmdFailure`. | ||
| /// | ||
| /// Every `TborStatus::Crypto*`/`CryptoCpt*` CPT (`CryptoController`)/// status is mapped 1:1 to its own `HsmError` variant of the same name,/// mirroring the FW-side range verbatim. |
Mirror Crypto Engine error code range (0x090A_xxxx) into HsmError and its TborStatus wire mirror, using the same names and numeric values, so the engine originated codes are directly representable without a translation layer. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Aakash Sasidharan (asasidharan)
force-pushed
the
asasidharan-mrvl/add-cryptocontroller-error-codes
branch
from
September 7, 2026 10:32
13f98bb to
54a5466
Compare
Copilot started reviewing on behalf of
Aakash Sasidharan (asasidharan)
September 7, 2026 10:33
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently add and validate the CPT error-code range across FW, wire status, and host mapping layers without altering existing codes or introducing behavioral regressions.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
Comment on lines
+100
to
+102
| /// Every `TborStatus::Crypto*`/`CryptoCpt*` CPT (`CryptoController`) status is | ||
| /// mapped 1:1 to its own `HsmError` variant of the same name, mirroring the | ||
| /// FW-side range verbatim. |
Comment on lines
+72
to
+74
| // -- CPT (CryptoController) host-facing errors ---------- | ||
| // 1:1 mirror of the TborStatus/HsmError (FW) CPT range. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror Crypto Engine error code range (0x090A_xxxx) into HsmError and its TborStatus wire mirror, using the same names and numeric values, so the engine originated codes are directly representable without a translation layer.