Implement depth-limit to GraphQL Queries/Mutation operations For Non-Hosted Scenario#2267
Merged
abhishekkumams merged 12 commits intomainfrom Jul 3, 2024
Merged
Conversation
Contributor
Author
|
/azp run |
Contributor
Author
|
/azp run |
ayush3797
reviewed
Jun 17, 2024
ayush3797
reviewed
Jun 17, 2024
ayush3797
reviewed
Jun 17, 2024
seantleonard
requested changes
Jun 17, 2024
Contributor
seantleonard
left a comment
There was a problem hiding this comment.
some test structure changes requested and more comments needed.
Contributor
seantleonard
left a comment
There was a problem hiding this comment.
some additional suggestions/nits based on latest changes.
… dev/abhishekkuma/add-nesting-limit-gql-queries
Contributor
Author
|
/azp run |
seantleonard
approved these changes
Jun 19, 2024
Contributor
seantleonard
left a comment
There was a problem hiding this comment.
few nits. Looks good! thank you for making these features additions and testing.
Contributor
Author
|
/azp run |
Contributor
Author
|
/azp run |
aaronburtle
reviewed
Jun 26, 2024
aaronburtle
reviewed
Jun 26, 2024
Contributor
Author
|
/azp run |
Contributor
Author
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
.AddMaxExecutionDepthRuleprovided by Hot Chocolate.dab.draft.schema.jsonfile to allow both integer and null value for depth-limit.How was this tested?
Sample Request(s)
#nested depth: 8
{ books(filter: {id: {eq: 1}}){ items{ id title publishers { id name books (filter: {authors: {id: {isNull: false}}}){ items { authors{ items{ id name } } } } } } } }nested depth: 3
{ book_by_pk(id: 2){ id publishers { id name } } }Mutation (nested depth: 7)