refactor(staleGet): refactor staleGet to randomize target endpoint#213
Open
vittoriasalim wants to merge 5 commits intomainfrom
Open
refactor(staleGet): refactor staleGet to randomize target endpoint#213vittoriasalim wants to merge 5 commits intomainfrom
vittoriasalim wants to merge 5 commits intomainfrom
Conversation
wonderyl
reviewed
Sep 11, 2025
| // Aggregates for DELETE and PATCH methods, replaces the last path segment | ||
| // for DELETE and PATCH requests so they can be aggregated (e.g. in metrics) | ||
| if reqr.method == http.MethodDelete || reqr.method == http.MethodPatch { | ||
| // Aggregates for DELETE, PATCH, and GET methods, replaces the last path segment |
Contributor
There was a problem hiding this comment.
Could you remove the comment in either line 42 or line 46 and only keep one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.