Wire testutils into msal instrumented tests + add instrumented PR pipeline, Fixes AB#3678342#2540
Wire testutils into msal instrumented tests + add instrumented PR pipeline, Fixes AB#3678342#2540p3dr0rv wants to merge 11 commits into
Conversation
…eline
- androidTest{Local,Dist}Implementation testutils with transitive=false so msal androidTest can use FlakyTestRetryRule/@RetryFlakyTest once the common submodule is bumped. transitive=false avoids a second BouncyCastle line on the instrumented classpath.
- pr-msal-instrumented.yml: PR-validation pipeline running msal:connectedLocalDebugAndroidTest on an emulator.
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Pull request overview
Adds infrastructure to make FlakyTestRetryRule / @RetryFlakyTest available to MSAL’s instrumented (androidTest) suite, and introduces a dedicated PR-validation pipeline that runs MSAL instrumented tests on an emulator.
Changes:
- Wire
testutilsintomsal’sandroidTestconfigurations (local + dist) withtransitive = false. - Add
pr-msal-instrumented.ymlto runmsal:connectedLocalDebugAndroidTestas a PR build validation pipeline and publish logs/reports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
msal/build.gradle |
Adds androidTestLocalImplementation / androidTestDistImplementation dependency wiring for testutils retry utilities. |
azure-pipelines/pull-request-validation/pr-msal-instrumented.yml |
New ADO pipeline to provision an emulator, run MSAL instrumented tests, and publish logcat + HTML reports. |
Ports the working common setup: macOS agent (emulator needs a hypervisor; Linux hosted agents have no /dev/kvm), openssl cert decode, arch-aware system-image ABI, bounded emulator boot wait.
…droom, boot retry)
…tu validation in AuthClientAndroidPipelines)
…instrumented-tests.yml template
|
❌ Work item link check failed. Description contains AB#3678342 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
|
❌ Invalid work item number: AB#3678342 ##. Work item number must be a valid integer. Click here to learn more. |
|
✅ Work item link check complete. Description contains link AB#3678342 to an Azure Boards work item. |
github-actions
Bot
changed the title
AB#3678342
What
Makes
FlakyTestRetryRule/@RetryFlakyTest(added in common) available to broker's instrumented (androidTest) suite (AADAuthenticator), and adds a PR-validation pipeline for instrumented tests.Changes
androidTestLocalImplementation/androidTestDistImplementationontestutilswithtransitive = false. This is important here: testutils otherwise drags a second BouncyCastle line (bcprov-jdk15to18vs thebcprov-jdk18onalready present) which brokemergeLocalDebugAndroidTestJavaResource. transitive=false pulls only the rule classes.pr-broker-instrumented.yml— runsAADAuthenticator:connectedLocalDebugAndroidTeston an emulator.Depends on
Common PR (AzureAD common-for-android #3181). The wiring is harmless before that lands;
@RetryFlakyTestbecomes usable once the common submodule is bumped to include the rule.