WIP: progressive read timeout review - #1
Open
BGQ99 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR prepares the progressive read timeout changes from apache#3409 for review.
Changes
OnReadOnePart()callback.Socket::SetFailed()instead of destroying the parsing context from the timer thread.ENOTSUP.SocketIdplumbing and initialize_socket_idwithINVALID_SOCKET_ID.EPROGREADTIMEOUT.http_c++example buffer handling, reader cleanup, and spelling.Verification
git diff --checkpassed.Known Test Coverage Gap
The active progressive-read test currently verifies successful continuous reading, but does not yet explicitly guarantee that the total transfer time exceeds the configured timeout while each inter-read interval remains below the timeout.
The production deadline-refresh logic is covered by the current behavior tests. The active-read timing test should be strengthened in a follow-up revision.
This is a draft for colleague review. No merge is intended yet.