feat: Tags!! by bmcwilliams96 · Pull Request #707 · BLeeEZ/amperfy

bmcwilliams96 · 2026-05-26T19:44:40Z

Tag Viewer

Adds a new "View Tags" page accessible from the context menu of each song. This page is only accessible if the given song has tags. Otherwise, the option will not show up.

By default, all tags will show, but the user has the option to filter which tags they want shown. This setting will be persistent amongst songs in the library. If a tag that has not been seen before is present in a song, it will be added to the filter list, and shown by default.

This gives the user an opportunity to have an info screen about the song they are listening to. The main use case would be for a "song credits" type screen, but it is up to the user how they want to use this page.

This new page is only present in-app and is not available in CarPlay.

Artists Tag

In addition to this change, there is also an adjustment to show the "Artists" tag as the artist for a song. Previously, we were only grabbing the first artist available, so a song by Thundercat and Tame Impala would just show "Thundercat". Now, it will show both, separated by a comma.

If the Artists tag is not available, it will fall back to the original parsing we were doing before.

This new comma separated artist shows up in all views (CarPlay, system now playing, song list, and in-app now playing)

Tests

A new test was also added for the new tag viewer page.

…g for a song when available in the ui

BLeeEZ

Hi,
First of all thank you for this PR.
It is always beneficial to store as much information as available for better database search and user experience.

There are two major points that needs to be matched:

Albums artists, artists, genres: all these attributes need to be linked to their DB entity not just string. This is needed to be available for searches and sorting.
The Ampache API needs to be supported as well.

BLeeEZ · 2026-05-27T09:15:34Z

+    persist()
+  }
+
+  private func persist() {


No direct UserDefaults access. Use User Settings that save it.

BLeeEZ · 2026-05-27T09:16:35Z

 				COPY_PHASE_STRIP = NO;
 				DEBUG_INFORMATION_FORMAT = dwarf;
-				DEVELOPMENT_TEAM = U3R6D65S8W;
+				DEVELOPMENT_TEAM = 8N5BD6J6TY;


Remove adjusted DEVELOPMENT_TEAM.

BLeeEZ · 2026-05-27T09:20:28Z

      "episode", songBuffer != nil {
+      // Multi-artist display string
+      if !collectedArtistNames.isEmpty {
+        songBuffer?.artistsString = collectedArtistNames.joined(separator: ", ")


why is it save as a String and not referencing the element directly as array. This would improve DB search.

BLeeEZ · 2026-05-27T09:22:24Z

+    set { managedObject.artistsString = newValue }
+  }
+
+  public var albumArtistsString: String? {


BLeeEZ · 2026-05-27T09:23:34Z

+    set { managedObject.channelCount = newValue }
+  }
+
+  public var samplingRate: Int32 {


Should only be Int. The wrapper is there to hide the actual size of the DB entry.

bmcwilliams96 · 2026-05-27T13:59:32Z

Hi,
First of all thank you for this PR.
It is always beneficial to store as much information as available for better database search and user experience.

There are two major points that needs to be matched:

Albums artists, artists, genres: all these attributes need to be linked to their DB entity not just string. This is needed to be available for searches and sorting.

The Ampache API needs to be supported as well.

Sounds good I will get an update pushed out as soon as possible! :)

bmcwilliams96 · 2026-06-01T23:26:20Z

Comment	Status
No direct `UserDefaults` access — use User Settings	✅ Fixed (`TagVisibilityStore` now uses `PersistentStorage.settings.user.hiddenSongTagKeys`)
`DEVELOPMENT_TEAM` should be reverted to org ID	✅ Just fixed — both debug/release configs reverted to `U3R6D65S8W`
Artists/albumArtists/genres should be `[Artist]`/`[Genre]` entity relationships, not strings	✅ Fixed (Core Data v51, new relationships, Song.swift computed wrappers)
`samplingRate`/`channelCount`/`bpm`/`bitDepth` wrapper should be `Int` not `Int16`/`Int32`	✅ Fixed
Ampache API needs to be supported	✅ Fixed (`SongParserDelegate` now handles `<albumartist>`, multi-`<genre>`, `<rate>`, `<channels>`, `<composer>`, `<comment>`, `<mbid>`)

bmcwilliams96 · 2026-06-01T23:34:29Z

oops forgot to run tests. Fix for the tests out in a bit

bmcwilliams96 · 2026-06-05T22:54:00Z

Finally fixed the tests! @BLeeEZ Sorry for the delay.

Summary of changes made:

AmperfyKit/Api/Ampache/IDsParserDelegate.swift:53 — Added "albumartist" to the element name case so the ID parser now collects albumartist IDs into prefetchIDs.artistIDs. This prevents duplicate artist creation across re-parses.

AmperfyKitTests/Cases/API/Ampache/PlaylistSongsParserTest.swift:133 — Updated artistCount from 4 to 5 to account for the albumartist "19" now being counted.

AmperfyKitTests/Cases/API/Ampache/SongParserTest.swift:44 — Updated artistCount from 4 to 5 for the same reason (same XML structure includes ).

bmcwilliams96 · 2026-06-29T20:05:42Z

@BLeeEZ let me know if I need to make any more changes to this PR. Would love to see this in the app if possible :)

BLeeEZ · 2026-06-30T18:32:32Z

@bmcwilliams96 this is a huge PR and I am currently quite limited with time that I can spend on this App. There a lot of topics that don't match Amperfy's software architecture and code style. It would need a deeper look of myself to get everything aligned.

bmcwilliams96 · 2026-07-03T04:38:02Z

@BLeeEZ Fully understood! I will also take a deeper look and try to make some more improvements. I just recently started a test Ampache server to help with testing. This way I can get you a better quality PR to review when you are ready. Thanks for all you do :)

brandon added 2 commits May 25, 2026 23:58

adding the ability to view tags for a song. also showing "artists" ta…

622f383

…g for a song when available in the ui

adding a test for the new tag functionality and applying formatting

e18ac20

BLeeEZ reviewed May 27, 2026

View reviewed changes

brandon added 2 commits June 1, 2026 19:17

addressing various pr comments

27ddd47

addressing pr comments

04c8e93

fixing tests

122f99d

Uh oh!

Conversation

bmcwilliams96 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tag Viewer

Artists Tag

Tests

Uh oh!

BLeeEZ left a comment

Choose a reason for hiding this comment

Uh oh!

BLeeEZ May 27, 2026

Choose a reason for hiding this comment

Uh oh!

BLeeEZ May 27, 2026

Choose a reason for hiding this comment

Uh oh!

BLeeEZ May 27, 2026

Choose a reason for hiding this comment

Uh oh!

BLeeEZ May 27, 2026

Choose a reason for hiding this comment

Uh oh!

BLeeEZ May 27, 2026

Choose a reason for hiding this comment

Uh oh!

bmcwilliams96 commented May 27, 2026

Uh oh!

bmcwilliams96 commented Jun 1, 2026

Uh oh!

bmcwilliams96 commented Jun 1, 2026

Uh oh!

bmcwilliams96 commented Jun 5, 2026

Uh oh!

bmcwilliams96 commented Jun 29, 2026

Uh oh!

BLeeEZ commented Jun 30, 2026

Uh oh!

bmcwilliams96 commented Jul 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bmcwilliams96 commented May 26, 2026 •

edited

Loading