add config.py for static cfg vars like LIBRESSL_PATH#3
add config.py for static cfg vars like LIBRESSL_PATH#3DanGould wants to merge 1 commit intoBUSEC:masterfrom
Conversation
| if(system() == "Darwin"): | ||
| path = "/usr/local/opt/libressl/lib/libssl.dylib" | ||
| try: | ||
| config.LIBRESSL_PATH |
There was a problem hiding this comment.
python noob here but why not path = config.LIBRESSL_PATH and removing the else at the end ?
There was a problem hiding this comment.
I believe if config.LIBRESSL_PATH isn't set i.e. commented out in the config it will throw a NameError, that was my thinking
There was a problem hiding this comment.
but path = config.LIBRESSL_PATH should as well right?
There was a problem hiding this comment.
Oh, I see what you're saying. set the path in the try statement instead of in else madness
`
There was a problem hiding this comment.
You should include this change in your updated pull request.
leen-she
left a comment
leen-she
left a comment
There was a problem hiding this comment.
Sorry, just saw this. Like your idea, it should work for now. Will merge after you update your pull request and make sure it doesn't conflict with master.
| @@ -0,0 +1,3 @@ | |||
| LIBRESSL_PATH = "/usr/local/lib/libssl.so" | |||
There was a problem hiding this comment.
This should be commented out. The user should uncomment and change to the correct path if the default paths don't work. Will mention this in the README.
| if(system() == "Darwin"): | ||
| path = "/usr/local/opt/libressl/lib/libssl.dylib" | ||
| try: | ||
| config.LIBRESSL_PATH |
There was a problem hiding this comment.
You should include this change in your updated pull request.
3 participants
Could also be used to set tumbler's address, etc