Repository navigation
Detail pages: dedicated dishwasher kitchen form art (Fixes #100) - #101
Merged
Merged
Conversation
Kitchen dishwasher models mapped to .kitchen were rendered with CookerArt. Add DeviceForm.dishwasher, DishwasherArt, and DishwasherDetail so dishwashers get their own form, art, and detail page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #100: kitchen dishwasher models get their own
DeviceForm.dishwasher+DishwasherArt/DishwasherDetailinstead of the rice-cookerCookerArtsilhouette (DESIGN「同类不同形」).DeviceForm.dishwasherwhencategory == .kitchenand model containsdishwasher(checked before kettle); list icondishwasherDishwasherArt(washing:tint:)boxy front-loader with top control strip and rectangular door window (not a washer porthole); washing state shows tinted droplets; wired throughoffArt+TypeDetailView→DishwasherDetaild29(viomi.dishwasher.demo) on homeh2kitchen with status Washing/Idle, remaining time, and writable modedishwasher(count 27); TypeDetailTests for d29 routing/props; cooker and kettle regressions keptdocs/DESIGN.md+i18n/zh-Hant.tsv/ Translations syncSelf-test
swift build/swift testgreen on Mac mini A (~/MijiaBar-auto)swift test: 359/359 passed (includes newdishwasherDemoRoutingAndProps)--snapshotrun inside Codex sandbox. Snapshot framesdishwasher/dishwasher-idleadded; orchestrator rendered them outside Codex for visual check.Authorship
Codex wrote the feature code on Mac mini A; orchestrator reviewed the diff, ran build/test, committed, and opened this PR.
Fixes #100
Out of scope
No release/appcast/Sparkle, no house fixture conversion, no remapping dishwasher to
.washer, no real-device control.