Repository navigation
Detail pages: dedicated juicer kitchen form art (Fixes #102) - #103
Merged
Merged
Conversation
Kitchen juicer models get DeviceForm.juicer + JuicerArt/JuicerDetail instead of CookerArt (DESIGN 同类不同形). Codex-authored on Mac mini A.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #102: kitchen juicer models get their own
DeviceForm.juicer+JuicerArt/JuicerDetailinstead of the rice-cookerCookerArtsilhouette (DESIGN「同类不同形」).DeviceForm.juicerwhencategory == .kitchenand model containsjuicer(after dishwasher / kettle); list iconcup.and.saucerJuicerArt(blending:tint:)tall pitcher-on-base with blending swirl; wired throughoffArt+TypeDetailView→JuicerDetaild30(xiaomi.juicer.demo) on homeh2kitchen with status Blending/Idle and writable modejuicer(count 28); TypeDetailTests for d30 routing/props; cooker/kettle/dishwasher regressions keptdocs/DESIGN.md+i18n/zh-Hant.tsv/ Translations syncScreenshots
Self-test
bash scripts/test.shon Mac mini A (~/MijiaBar-auto): 360/360 passed (includes newjuicerDemoRoutingAndProps)--snapshotframes outside Codex for visual check (juicer/juicer-idlelight+dark)Authorship
Codex wrote the feature code on Mac mini A; orchestrator reviewed the diff, ran build/test, committed, and opened this PR.
Fixes #102
Out of scope
No release/appcast/Sparkle, no house fixture conversion, no induction cooktop (
ihcooker) in this PR, no real-device control.