Repository navigation
Detail pages: dedicated induction cooktop (ihcooker) kitchen form art (Fixes #104) - #105
Merged
Merged
Conversation
Fixes #104. Kitchen ihcooker models get DeviceForm.ihcooker, IHCookerArt (flat plate + coil glow) and IHCookerDetail instead of the rice-cooker CookerArt silhouette. Adds mock d31, ArtGallery row, TypeDetailTests, and DESIGN / zh-Hant sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #104: kitchen induction cooktop models (
*.ihcooker*) get their ownDeviceForm.ihcooker+IHCookerArt/IHCookerDetailinstead of the rice-cookerCookerArtsilhouette (DESIGN「同类不同形」).DeviceForm.ihcookerwhencategory == .kitchenand model containsihcooker(after dishwasher / kettle / juicer); list iconcooktopIHCookerArt(heating:tint:)flat plate with coil glow when heating; wired throughoffArt+TypeDetailView→IHCookerDetaild31(chunmi.ihcooker.demo) on homeh2kitchen with status Heating/Idle, writable heat-level and modeihcooker(count 29); TypeDetailTests for d31 routing/props plus generic-cookernon-match; cooker/kettle/dishwasher/juicer regressions keptdocs/DESIGN.md+i18n/zh-Hant.tsv/ Translations syncScreenshots
Self-test
bash scripts/test.shon Mac mini A (~/MijiaBar-auto): 362/362 passed (includes newihcookerDemoRoutingAndPropsandihcookerFormDoesNotMatchGenericCooker)--snapshotframes outside Codex for visual check (ihcooker/ihcooker-idlelight+dark)Authorship
Codex wrote the feature code on Mac mini A; orchestrator reviewed the diff, ran build/test, committed, and opened this PR.
Fixes #104
Out of scope
No release/appcast/Sparkle, no house fixture conversion, no leftover kitchen shapes such as
mfcp, no real-device control.