Repository navigation
Detail pages: dedicated multifunction cooking pot (mfcp) kitchen form art (Fixes #107) - #108
Merged
Merged
Conversation
… art (Fixes #107) Kitchen mfcp models get DeviceForm.mfcp, MfcpArt, and MfcpDetail instead of the rice-cooker CookerArt silhouette. Adds mock d32, ArtGallery row, TypeDetailTests, and DESIGN / zh-Hant sync. Codex authored the code on Mac mini A.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #107: kitchen multifunction cooking pot models (
*.mfcp*) get their ownDeviceForm.mfcp+MfcpArt/MfcpDetailinstead of the rice-cookerCookerArtsilhouette (DESIGN「同类不同形」).DeviceForm.mfcpwhencategory == .kitchenand model containsmfcp(after dishwasher / kettle / juicer / ihcooker); list iconfrying.panMfcpArt(cooking:tint:)wide shallow pot with domed lid, side handles, and short heating base; warm glow and steam when cooking; wired throughoffArt+TypeDetailView→MfcpDetaild32(chunmi.mfcp.demo) on homeh2kitchen with status Cooking/Idle, mode, left-time, heat-level, and temperaturemfcp(count 30); TypeDetailTests for d32 routing/props plus form-precedence so mfcp does not steal cooker / kettle / dishwasher / juicer / ihcookerdocs/DESIGN.md+i18n/zh-Hant.tsv/ Translations syncScreenshots
Self-test
bash scripts/test.shon Mac mini A (~/MijiaBar-auto): 364/364 passed (includes newmfcpDemoRoutingAndPropsandmfcpFormDoesNotStealOtherKitchenForms)--snapshotframes outside Codex for visual check (mfcp/mfcp-idlelight+dark)Authorship
Codex wrote the feature code on Mac mini A; orchestrator reviewed the diff, ran build/test, committed, and opened this PR.
Fixes #107
Out of scope
No release/appcast/Sparkle, no house fixture conversion, no other leftover kitchen shapes (generic
cookerremaining onCookerArtis intended), no real-device control.