Repository navigation
Detail pages: dedicated kettle kitchen form art (Fixes #98) - #99
Merged
Merged
Conversation
Add DeviceForm.kettle + KettleArt/KettleDetail so kettle models no longer reuse CookerArt; mock d28, ArtGallery row, TypeDetailTests, DESIGN + zh-Hant sync. Codex authored the code; orchestrator verified with swift build / swift test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #98: kitchen kettle models get their own
DeviceForm.kettle+KettleArt/KettleDetailinstead of the rice-cookerCookerArtsilhouette (DESIGN「同类不同形」).DeviceForm.kettlewhencategory == .kitchenand model containskettle; list iconmugKettleArt(boiling:tint:)tall kettle body/handle/spout with on/off steam; wired throughoffArt+TypeDetailView→KettleDetaild28(yunmi.kettle.demo) on homeh2kitchen with writable target temp + boiling statuskettle(count 26); TypeDetailTests for d28 routing/props; cooker regression keptdocs/DESIGN.md+i18n/zh-Hant.tsv/ Translations syncSelf-test
swift buildgreen on Mac mini A (~/MijiaBar-auto)swift test: 358/358 passed (includes newkettleDemoRoutingAndProps)--snapshotrun in Codex sandbox; snapshot render hooks for kettle/kettle-idle added for later captureAuthorship
Codex wrote the feature code on Mac mini A; orchestrator reviewed the diff, ran build/test, committed, and opened this PR.
Fixes #98
Out of scope
No release/appcast/Sparkle, no house fixture conversion, no real-device control.