Skip to content

Draft handoff: Browser/Glance dragging and Peek cancellation - #320

Closed
skyswordw wants to merge 4 commits into
mainfrom
codex/glance-drag-peek
Closed

skyswordw wants to merge 4 commits into
mainfrom
codex/glance-drag-peek

Conversation

@skyswordw

@skyswordw skyswordw commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Paused at the user's request. Claude Code leads the next interaction/motion pass in #332. This PR remains an experimental draft, not an accepted fix or visual target. Do not merge it on test counts alone.

The user reports that the first Glance drag could start, later drags often became range selection, and a drag image remained on screen. Peek was no longer obstructing the gesture. The user rejected the current visual result and requested that Browser's earlier drag-feedback/cross-archive workflow be reviewed together with Glance.

This branch preserves the candidate for Claude to inspect, modify or replace:

  • Current archive ownership for retained Browser/Glance windows; pressed-row hit testing across table columns.
  • Peek cancellation while pending or visible, with normal hover-only neighbor timing retained.
  • Native table gestures and unconsumed AppKit events. The latest checkpoint starts the session from the recognizer action after arbitration, rejects released pending actions and overlapping starts, resets at session completion, and gives the file-drag decision priority over primary-mouse table selection gestures.
  • Regression tests for retained windows, stale hosts/presses, repeated drags, selection/cancellation, early release, refused-start retry and preview interruption.

Evidence at the pause

The last completed local run passed 728 tests in 106 suites before testing was paused. The prior committed candidate passed CI and all 1276 strings had Simplified Chinese translations; this checkpoint adds no product strings. These results do not establish physical gesture or motion acceptance.

Earlier temporary native receiver checks delivered real files/folders and verified exact bytes, Keep Both, round-trip/Size-column dragging and cancellation. They required staged CUA input and did not catch the user's subsequent repeated-drag/lingering-image report. The receiver and logging were removed. The latest isolated review build is 32002 and has no physical acceptance.

See the current evidence and limitations and the actionable Claude Code brief in #332. Keep #318 open. Browser's accepted cross-archive copy/Undo/Redo/Save baseline from #308/#311 must be preserved while its feedback and shared gestures are reviewed.

Claude Code owns the next visual/motion and interaction correction requested by the user; no Claude session or review is claimed. Preserve archive safety, scoped state, asynchronous promises, cancellation and keyboard semantics. Dedicated VoiceOver acceptance remains deferred; #93 stays separate. Installed app extensions were not replaced.

@skyswordw skyswordw changed the title Fix Glance drag-out and suppress Peek during mouse interactions Draft handoff: Browser/Glance dragging and Peek cancellation Nov 7, 2026
@skyswordw

Copy link
Copy Markdown
Member Author

Closing this experimental draft as superseded by merged #336 and #337, following the user's request to finish processing the remaining PRs.

#336 preserves the required retained-window routing, file promises, transfer safety and Peek cancellation while replacing this draft's competing gesture recognizer with native table dragging. #337 completes the related extraction-target/layout refinement. Their PRs record the later hands-on acceptance; the combined main tree passed 731 local tests with zero failures/skips and all PR CI checks. Issues #318 and #332 are closed.

This does not merge or approve the abandoned gesture implementation. Its branch and historical evidence remain available. Claude Code owns the replacement visual/motion treatment; Codex completed functional review. Broader #104/#161/#38 acceptance and deferred VoiceOver #93 remain separate.

@skyswordw skyswordw closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant