Repository navigation
docs: Record BIP138 security audit - #237
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 050a153887
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a5a4538 to
2fe68cf
Compare
|
Base branch #230 advanced during review; this PR is now non-mergeable against the current base. Please rebase onto the current |
Record the reviewed BIP138 recovery findings, pinned revisions, revalidation status, and Bails integration requirements as one documentation change. Closes #236.
2fe68cf to
4e1cd48
Compare
This comment has been minimized.
This comment has been minimized.
|
@codex review this PR |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
looks good to me, documentation only changes about BIP138 support in bails. Recommend delaying until the weaknesses are ironed out and well reviewed implementations exist.
Rebuilt onto 201-simplify-this-project-by-removing-bails-wallet. The previous branch shared no ancestor with its own base: its first commit was a repository root holding a whole-tree snapshot, so every file collided as added-by-both and the branch carried a stale copy of the tree alongside the feature. Replayed here is only what the branch actually contributed: the install-codex32 and open-codex32 scripts, the Codex32 desktop entry, the security documentation merged as #237, and the README text describing the restore flow. Deliberately not replayed are the four files where the snapshot was simply older than master and would have reverted it, namely chainstate-preload, install-core, link-dotfiles and the bitcoin-qt desktop entry, together with the three documents the base has since consolidated.
1 participant
Closes #236.
Records the recovery audit verdict and Bails integration requirements for BIP138.
Key boundary: successful BIP138 decryption must not authorize descriptor activation. Imported policy stays inactive/quarantined until independently committed wallet/policy identity is verified.
Also records the Codex32 set-authentication limits relevant to Bails and the ChaCha20-Poly1305 implementation note.
Validation:
git diff --checkpasses.